Re: [PATCH 5/6] target/s390x/cpu_models: Make kvm_s390_apply_cpu_model() return boolean

[Thomas Huth]

On 19/04/2024 08.57, Zhao Liu wrote:
> From: Zhao Liu <zhao1.liu@intel.com>
>
> As error.h suggested, the best practice for callee is to return
> something to indicate success / failure.
>
> So make kvm_s390_apply_cpu_model() return boolean and check the
> returned boolean in apply_cpu_model() instead of accessing @err.
>
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> ---
>   target/s390x/cpu_models.h        |  5 +++--
>   target/s390x/cpu_models_sysemu.c |  3 +--
>   target/s390x/kvm/kvm.c           | 15 ++++++++-------
>   3 files changed, 12 insertions(+), 11 deletions(-)

Reviewed-by: Thomas Huth <thuth@redhat.com>