[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH-for-9.1 01/21] target/i386: Declare CPU QOM types using DEFINE_TY
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH-for-9.1 01/21] target/i386: Declare CPU QOM types using DEFINE_TYPES() macro |
Date: |
Fri, 15 Mar 2024 14:08:49 +0100 |
When multiple QOM types are registered in the same file,
it is simpler to use the the DEFINE_TYPES() macro. In
particular because type array declared with such macro
are easier to review.
In few commits we are going to add more types, so replace
the type_register_static() to ease further reviews.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
Message-Id: <20231013140116.255-14-philmd@linaro.org>
---
target/i386/cpu.c | 50 ++++++++++++++++++++++-------------------------
1 file changed, 23 insertions(+), 27 deletions(-)
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 9a210d8d92..ebf555f50f 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -4991,13 +4991,6 @@ static void max_x86_cpu_initfn(Object *obj)
&error_abort);
}
-static const TypeInfo max_x86_cpu_type_info = {
- .name = X86_CPU_TYPE_NAME("max"),
- .parent = TYPE_X86_CPU,
- .instance_init = max_x86_cpu_initfn,
- .class_init = max_x86_cpu_class_init,
-};
-
static char *feature_word_description(FeatureWordInfo *f, uint32_t bit)
{
assert(f->type == CPUID_FEATURE_WORD || f->type == MSR_FEATURE_WORD);
@@ -8041,19 +8034,6 @@ static void x86_cpu_common_class_init(ObjectClass *oc,
void *data)
}
}
-static const TypeInfo x86_cpu_type_info = {
- .name = TYPE_X86_CPU,
- .parent = TYPE_CPU,
- .instance_size = sizeof(X86CPU),
- .instance_align = __alignof(X86CPU),
- .instance_init = x86_cpu_initfn,
- .instance_post_init = x86_cpu_post_initfn,
-
- .abstract = true,
- .class_size = sizeof(X86CPUClass),
- .class_init = x86_cpu_common_class_init,
-};
-
/* "base" CPU model, used by query-cpu-model-expansion */
static void x86_cpu_base_class_init(ObjectClass *oc, void *data)
{
@@ -8065,22 +8045,38 @@ static void x86_cpu_base_class_init(ObjectClass *oc,
void *data)
xcc->ordering = 8;
}
-static const TypeInfo x86_base_cpu_type_info = {
- .name = X86_CPU_TYPE_NAME("base"),
- .parent = TYPE_X86_CPU,
- .class_init = x86_cpu_base_class_init,
+static const TypeInfo x86_cpu_types[] = {
+ {
+ .name = TYPE_X86_CPU,
+ .parent = TYPE_CPU,
+ .abstract = true,
+ .instance_size = sizeof(X86CPU),
+ .instance_align = __alignof(X86CPU),
+ .instance_init = x86_cpu_initfn,
+ .instance_post_init = x86_cpu_post_initfn,
+ .class_size = sizeof(X86CPUClass),
+ .class_init = x86_cpu_common_class_init,
+ }, {
+ .name = X86_CPU_TYPE_NAME("base"),
+ .parent = TYPE_X86_CPU,
+ .class_init = x86_cpu_base_class_init,
+ }, {
+ .name = X86_CPU_TYPE_NAME("max"),
+ .parent = TYPE_X86_CPU,
+ .instance_init = max_x86_cpu_initfn,
+ .class_init = max_x86_cpu_class_init,
+ }
};
+DEFINE_TYPES(x86_cpu_types)
+
static void x86_cpu_register_types(void)
{
int i;
- type_register_static(&x86_cpu_type_info);
for (i = 0; i < ARRAY_SIZE(builtin_x86_defs); i++) {
x86_register_cpudef_types(&builtin_x86_defs[i]);
}
- type_register_static(&max_x86_cpu_type_info);
- type_register_static(&x86_base_cpu_type_info);
}
type_init(x86_cpu_register_types)
--
2.41.0
- [RFC PATCH-for-9.1 00/21] qapi: Make @query-cpu-definitions command target-agnostic, Philippe Mathieu-Daudé, 2024/03/15
- [PATCH-for-9.1 01/21] target/i386: Declare CPU QOM types using DEFINE_TYPES() macro,
Philippe Mathieu-Daudé <=
- [PATCH-for-9.1 02/21] target/mips: Declare CPU QOM types using DEFINE_TYPES() macro, Philippe Mathieu-Daudé, 2024/03/15
- [PATCH-for-9.1 03/21] target/ppc: Declare CPU QOM types using DEFINE_TYPES() macro, Philippe Mathieu-Daudé, 2024/03/15
- [PATCH-for-9.1 04/21] target/sparc: Declare CPU QOM types using DEFINE_TYPES() macro, Philippe Mathieu-Daudé, 2024/03/15
- [PATCH-for-9.1 08/21] target/sparc: Make SPARC_CPU common to new SPARC32_CPU/SPARC64_CPU types, Philippe Mathieu-Daudé, 2024/03/15
- [PATCH-for-9.1 05/21] cpus: Open code OBJECT_DECLARE_TYPE() in OBJECT_DECLARE_CPU_TYPE(), Philippe Mathieu-Daudé, 2024/03/15
- [PATCH-for-9.1 09/21] qapi: Merge machine-common.json with qapi/machine.json, Philippe Mathieu-Daudé, 2024/03/15