[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 15/23] cpu: call plugin init hook asynchronously
From: |
Alex Bennée |
Subject: |
[PATCH 15/23] cpu: call plugin init hook asynchronously |
Date: |
Fri, 16 Feb 2024 16:30:17 +0000 |
From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
This ensures we run during a cpu_exec, which allows to call start/end
exclusive from this init hook (needed for new scoreboard API introduced
later).
async work is run before any tb is translated/executed, so we can
guarantee plugin init will be called before any other hook.
The previous change made sure that any idle/resume cb call will not be
done before initializing plugin for a given vcpu.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Message-Id: <20240213094009.150349-5-pierrick.bouvier@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
hw/core/cpu-common.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/hw/core/cpu-common.c b/hw/core/cpu-common.c
index fe16d0d9df8..68786360ea5 100644
--- a/hw/core/cpu-common.c
+++ b/hw/core/cpu-common.c
@@ -194,6 +194,11 @@ static void cpu_common_parse_features(const char
*typename, char *features,
}
}
+static void qemu_plugin_vcpu_init__async(CPUState *cpu, run_on_cpu_data unused)
+{
+ qemu_plugin_vcpu_init_hook(cpu);
+}
+
static void cpu_common_realizefn(DeviceState *dev, Error **errp)
{
CPUState *cpu = CPU(dev);
@@ -217,9 +222,9 @@ static void cpu_common_realizefn(DeviceState *dev, Error
**errp)
cpu_resume(cpu);
}
- /* Plugin initialization must wait until the cpu is fully realized. */
+ /* Plugin initialization must wait until the cpu start executing code */
if (tcg_enabled()) {
- qemu_plugin_vcpu_init_hook(cpu);
+ async_run_on_cpu(cpu, qemu_plugin_vcpu_init__async, RUN_ON_CPU_NULL);
}
/* NOTE: latest generic point where the cpu is fully realized */
--
2.39.2
- Re: [PATCH 18/23] plugins: add an API to read registers, (continued)
- Re: [PATCH 18/23] plugins: add an API to read registers, Akihiko Odaki, 2024/02/22
- Re: [PATCH 18/23] plugins: add an API to read registers, Alex Bennée, 2024/02/22
- Re: [PATCH 18/23] plugins: add an API to read registers, Akihiko Odaki, 2024/02/22
- Re: [PATCH 18/23] plugins: add an API to read registers, Alex Bennée, 2024/02/22
- Re: [PATCH 18/23] plugins: add an API to read registers, Akihiko Odaki, 2024/02/23
- Re: [PATCH 18/23] plugins: add an API to read registers, Alex Bennée, 2024/02/23
- Re: [PATCH 18/23] plugins: add an API to read registers, Alex Bennée, 2024/02/23
[PATCH 19/23] contrib/plugins: fix imatch, Alex Bennée, 2024/02/16
[PATCH 17/23] gdbstub: expose api to find registers, Alex Bennée, 2024/02/16
[PATCH 21/23] docs/devel: lift example and plugin API sections up, Alex Bennée, 2024/02/16
[PATCH 15/23] cpu: call plugin init hook asynchronously,
Alex Bennée <=
[PATCH 14/23] plugins: fix order of init/idle/resume callback, Alex Bennée, 2024/02/16
[PATCH 16/23] plugins: Use different helpers when reading registers, Alex Bennée, 2024/02/16