qemu-s390x
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] docs/s390: Fix wrong command example in s390-cpu-topology


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2] docs/s390: Fix wrong command example in s390-cpu-topology.rst
Date: Tue, 28 Nov 2023 14:14:21 +0100
User-agent: Mozilla Thunderbird

On 27/11/23 14:49, Zhao Liu wrote:
From: Zhao Liu <zhao1.liu@intel.com>

 From s390_possible_cpu_arch_ids() in hw/s390x/s390-virtio-ccw.c, the
"core-id" is the index of possible_cpus->cpus[], so it should only be
less than possible_cpus->len, which is equal to ms->smp.max_cpus.

Fix the wrong "core-id" 112, because it isn't less than maxcpus (36) in
-smp, and the valid core ids are 0-35 inclusive.

Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
Reviewed-by: Nina Schoetterl-Glausch <nsg@linux.ibm.com>
---
Changes since v1 RFC:
  * Fixed typo. (Nina)
  * Polished the description of the reason for fixing the wrong core-id.
    (Nina)
---
  docs/devel/s390-cpu-topology.rst | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

Patch queued, thanks!

Phil.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]