[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/3] hw/s390x: Don't call register_savevm_live() during insta
|
From: |
Eric Farman |
|
Subject: |
Re: [PATCH 0/3] hw/s390x: Don't call register_savevm_live() during instance_init() |
|
Date: |
Fri, 20 Oct 2023 10:05:48 -0400 |
|
User-agent: |
Evolution 3.48.4 (3.48.4-1.fc38) |
On Fri, 2023-10-20 at 14:57 +0200, Thomas Huth wrote:
> We must not call register_savevm_live() during instance_init()
> since instances can be created at any time, e.g. during introspection
> of a device. We must register the savevm handler during realize()
> instead. Fix it now in the s390x devices.
>
> Thomas Huth (3):
> hw/s390x/s390-skeys: Don't call register_savevm_live() during
> instance_init()
> hw/s390x/s390-stattrib: Simplify handling of the "migration-
> enabled"
> property
> hw/s390x/s390-stattrib: Don't call register_savevm_live() during
> instance_init()
>
> hw/s390x/s390-skeys.c | 35 ++++++--------------------
> hw/s390x/s390-stattrib.c | 54 +++++++++++++++-----------------------
> --
> 2 files changed, 28 insertions(+), 61 deletions(-)
Man, this makes it a lot easier to read too. With the amended patch 3:
Reviewed-by: Eric Farman <farman@linux.ibm.com>