Re: [PATCH v2 2/2] tests/tcg: Add -fno-stack-protector

[Alex Bennée]

Thomas Huth <thuth@redhat.com> writes:

> On 31/07/2023 11.10, Akihiko Odaki wrote:
>> A build of GCC 13.2 will have stack protector enabled by default if it
>> was configured with --enable-default-ssp option. For such a compiler,
>> it is necessary to explicitly disable stack protector when linking
>> without standard libraries.
>> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
>> ---
>>   tests/tcg/mips/hello-mips.c       | 4 ++--
>>   tests/tcg/Makefile.target         | 2 +-
>>   tests/tcg/aarch64/Makefile.target | 2 +-
>>   tests/tcg/arm/Makefile.target     | 2 +-
>>   tests/tcg/cris/Makefile.target    | 2 +-
>>   tests/tcg/hexagon/Makefile.target | 2 +-
>>   tests/tcg/i386/Makefile.target    | 2 +-
>>   tests/tcg/minilib/Makefile.target | 2 +-
>>   tests/tcg/mips/Makefile.target    | 2 +-
>>   9 files changed, 10 insertions(+), 10 deletions(-)
>> diff --git a/tests/tcg/mips/hello-mips.c
>> b/tests/tcg/mips/hello-mips.c
>> index 4e1cf501af..0ba5f1bf23 100644
>> --- a/tests/tcg/mips/hello-mips.c
>> +++ b/tests/tcg/mips/hello-mips.c
>> @@ -5,8 +5,8 @@
>>   * http://www.linux-mips.org/wiki/MIPSABIHistory
>>   * http://www.linux.com/howtos/Assembly-HOWTO/mips.shtml
>>   *
>> -* mipsel-linux-gcc -nostdlib -mno-abicalls -fno-PIC -mabi=32 \
>> -*                  -O2 -static -o hello-mips hello-mips.c
>> +* mipsel-linux-gcc -nostdlib -mno-abicalls -fno-PIC -fno-stack-protector \
>> +                   -mabi=32 -O2 -static -o hello-mips hello-mips.c
>
> You've lost the "*" at the beginning of the comment line here.
>
> But apart from that nit, the patch looks sane to me.
>
> Cc:-ing Alex Bennée ... could pick this patch up?

Queued to testing/next with tweak to comment, thanks.

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro