Re: [PATCH v1 2/2] target/s390x: flag te and cte as deprecated

[David Hildenbrand]

On 11.09.23 22:52, Collin Walling wrote:
> Add the CONSTRAINT_TRANSACTIONAL_EXE (cte) and TRANSACTIONAL_EXE (te)
> under the list of deprecated features.
>
> Signed-off-by: Collin Walling <walling@linux.ibm.com>
> ---
>   target/s390x/cpu_features.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/target/s390x/cpu_features.c b/target/s390x/cpu_features.c
> index efafc9711c..cb4e2b8920 100644
> --- a/target/s390x/cpu_features.c
> +++ b/target/s390x/cpu_features.c
> @@ -218,6 +218,9 @@ void s390_get_deprecated_features(S390FeatBitmap features)
>            /* CSSKE is deprecated on newer generations */
>            S390_FEAT_CONDITIONAL_SSKE,
>            S390_FEAT_BPB,
> +         /* Deprecated on z16 */
> +         S390_FEAT_CONSTRAINT_TRANSACTIONAL_EXE,
> +         S390_FEAT_TRANSACTIONAL_EXE
>       };
>       int i;
>   

We don't have to consider them in init_ignored_base_feat, because they 
have never been part of base model I guess?

--
Cheers,

David / dhildenb