Re: [PATCH 4/8] hw/core/cpu: Return static value with gdb_arch_name()

[Akihiko Odaki]

On 2023/09/04 14:54, Michael Tokarev wrote:
> 03.09.2023 07:30, Akihiko Odaki wrote:
> > All implementations of gdb_arch_name() returns dynamic duplicates of
> > static strings. It's also unlikely that there will be an implementation
> > of gdb_arch_name() that returns a truly dynamic value due to the nature
> > of the function returning a well-known identifiers. Qualify the value
> > gdb_arch_name() with const and make all of its implementations return
> > static strings.
>
> Why it needs to be a function, can't it be a char pointer
> initialized at the cpu init time?

There is no real reason I guess. Either is fine in my opinion.

> Reviewed-By: Michael Tokarev <mjt@tls.msk.ru>
>
> (What a huge list of recipients in the Cc..)
>
> /mjt