[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests/avocado/migration: Remove the malfunctioning s390x tes
From: |
Juan Quintela |
Subject: |
Re: [PATCH] tests/avocado/migration: Remove the malfunctioning s390x tests |
Date: |
Mon, 24 Jul 2023 11:03:12 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Thomas Huth <thuth@redhat.com> wrote:
> The tests from tests/avocado/migration.py do not work at all
> on s390x - the bios shuts down immediately when it cannot find
> a boot disk, so there is nothing left to migrate here. For doing
> a proper migration test, we would need a proper payload, but we
> already do such tests in the migration *qtest*, so it is unnecessary
> to redo such a test here, thus let's simply remove this test.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
> ---
> I'm tempted to remove this file completely - what test coverage do
> we get here that we don't get by tests/qtest/migration-test.c already?
Nothing new there, just three small tests. That are included in
migration-test.c
I agree we can drop it if we want to.
Later, Juan.