[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] pc-bios/s390-ccw: Get rid of the the __u* types
From: |
Eric Farman |
Subject: |
Re: [PATCH] pc-bios/s390-ccw: Get rid of the the __u* types |
Date: |
Tue, 27 Jun 2023 08:03:04 -0400 |
User-agent: |
Evolution 3.48.3 (3.48.3-1.fc38) |
On Tue, 2023-06-27 at 13:41 +0200, Thomas Huth wrote:
> Using types starting with double underscores should be avoided since
> these
> names are marked as reserved by the C standard. The corresponding
> Linux
> kernel header file has also been changed accordingly a long time ago:
>
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/dif
> f/drivers/s390/cio/cio.h?id=cd6b4f27b9bb2a
>
> So we should get rid of the __u* in the s390-ccw bios now finally,
> too.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> Based-on: <20230510143925.4094-4-quintela@redhat.com>
>
> pc-bios/s390-ccw/cio.h | 232 ++++++++++++++++++----------------
> --
> pc-bios/s390-ccw/s390-ccw.h | 4 -
> 2 files changed, 116 insertions(+), 120 deletions(-)
Thanks for the based-on hint.
Reviewed-by: Eric Farman <farman@linux.ibm.com>