Re: [PATCH 1/2] linux-headers: Update with vfio_ap IRQ index mapping

[Anthony Krowiak]

On 5/30/23 8:56 PM, Matthew Rosato wrote:
> On 5/30/23 6:55 PM, Tony Krowiak wrote:
> > Signed-off-by: Tony Krowiak <akrowiak@linux.ibm.com>
> > ---
> >   linux-headers/linux/vfio.h | 9 +++++++++
> >   1 file changed, 9 insertions(+)
>
> Worth nothing here that linux-headers patches should be generated using 
> scripts/update-linux-headers.sh.
>
> Since this linux-headers update includes changes that aren't merged into the 
> kernel yet, I would still use update-linux-headers.sh -- but also include in 
> the commit message that this is a placeholder patch that includes unmerged uapi 
> changes.  Then once the kernel changes merge you can just have a proper 
> linux-headers update patch in a subsequent qemu series.

I guess I do not understand the procedure here. I first determined the 
latest kernel release in which the vfio.h file was updated with the 
following command:
git log --oneline origin/master -- linux-headers/linux/vfio.h

According to the git log, the vfio.h file was last updated in kernel 
v6.3-rc5. I cloned that kernel from 
git.kernel.org/pub/scm/linux/kernel/git/stable and checked out kernel 
6.3-rc5. I then made the changes to the linux-headers/linux/vfio.h file 
and ran the update-linux-headers.sh script and created this patch from 
that. Where did I go wrong?

> > diff --git a/linux-headers/linux/vfio.h b/linux-headers/linux/vfio.h
> > index 4a534edbdcba..2658fda219e8 100644
> > --- a/linux-headers/linux/vfio.h
> > +++ b/linux-headers/linux/vfio.h
> > @@ -646,6 +646,15 @@ enum {
> >         VFIO_CCW_NUM_IRQS
> >   };
> >   
> > +/*
> > + * The vfio-ap bus driver makes use of the following IRQ index mapping.
> > + * Unimplemented IRQ types return a count of zero.
> > + */
> > +enum {
> > +       VFIO_AP_REQ_IRQ_INDEX,
> > +       VFIO_AP_NUM_IRQS
> > +};
> > +
> >   /**
> >    * VFIO_DEVICE_GET_PCI_HOT_RESET_INFO - _IOWR(VFIO_TYPE, VFIO_BASE + 12,
> >    *                                          struct vfio_pci_hot_reset_info)