[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/5] meson: replace submodules with wrap files
From: |
Paolo Bonzini |
Subject: |
Re: [PATCH 0/5] meson: replace submodules with wrap files |
Date: |
Tue, 30 May 2023 15:22:55 +0200 |
On Tue, May 30, 2023 at 2:57 PM Daniel P. Berrangé <berrange@redhat.com> wrote:
> > > I'm not sure what's the best way to proceed for roms/SLOF. Some
> > > possibilities, in no particular order, include:
> > >
> > > * doing nothing
> > >
> > > * merging --with-git-submodules with --enable-download, and
> > > moving the git-submodule.sh rules from the main Makefile to
> > > pc-bios/s390-ccw/ (my favorite option)
> > >
> > > * copying the relevant SLOF files into pc-bios/
> >
> > Considering that SLOF is also rather on life support already (there is now
> > VOF for the sPAPR machine instead, Alexey left IBM, ...), I also wouldn't
> > mind the third option, I think.
> >
> > But of course we can also start with option 2 and go for option 3 later.
>
> My inclination would be for option 3 too, just copy the relevant files
> into s390-ccw dir, so the two distinct ROMs are fully separated from
> each other.
Note that the amount of code is not small (7.000 lines of source for the
network stack and 1.000 for libc); but yeah, that can be done.
Paolo