qemu-s390x
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 07/10] hw/virtio/vhost-vsock: Include missing 'virtio/virt


From: Stefano Garzarella
Subject: Re: [PATCH v2 07/10] hw/virtio/vhost-vsock: Include missing 'virtio/virtio-bus.h' header
Date: Fri, 26 May 2023 14:29:18 +0200

On Wed, May 24, 2023 at 11:37:41AM +0200, Philippe Mathieu-Daudé wrote:
Instead of having "virtio/virtio-bus.h" implicitly included,
explicitly include it, to avoid when rearranging headers:

 hw/virtio/vhost-vsock-common.c: In function ‘vhost_vsock_common_start’:
 hw/virtio/vhost-vsock-common.c:51:5: error: unknown type name 
‘VirtioBusClass’; did you mean ‘VirtioDeviceClass’?
    51 |     VirtioBusClass *k = VIRTIO_BUS_GET_CLASS(qbus);
       |     ^~~~~~~~~~~~~~
       |     VirtioDeviceClass
 hw/virtio/vhost-vsock-common.c:51:25: error: implicit declaration of function 
‘VIRTIO_BUS_GET_CLASS’; did you mean ‘VIRTIO_DEVICE_CLASS’? 
[-Werror=implicit-function-declaration]
    51 |     VirtioBusClass *k = VIRTIO_BUS_GET_CLASS(qbus);
       |                         ^~~~~~~~~~~~~~~~~~~~
       |                         VIRTIO_DEVICE_CLASS

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
---
hw/virtio/vhost-vsock-common.c | 1 +
1 file changed, 1 insertion(+)

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]