Re: [PATCH v2 15/27] target/s390x: Use tcg_gen_qemu_{ld, st}_i128 for LPQ, STPQ

[David Hildenbrand]

On 23.05.23 15:47, Richard Henderson wrote:
> No need to roll our own, as this is now provided by tcg.
> This was the last use of retxl, so remove that too.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> Cc: qemu-s390x@nongnu.org
> Cc: David Hildenbrand <david@redhat.com>
> Cc: Ilya Leoshkevich <iii@linux.ibm.com>
> ---
>   target/s390x/cpu.h               |  3 --
>   target/s390x/helper.h            |  4 ---
>   target/s390x/tcg/mem_helper.c    | 61 --------------------------------
>   target/s390x/tcg/translate.c     | 30 +++++-----------
>   target/s390x/tcg/insn-data.h.inc |  2 +-
>   5 files changed, 9 insertions(+), 91 deletions(-)
>
> diff --git a/target/s390x/cpu.h b/target/s390x/cpu.h
> index c47e7adcb1..f130c29f83 100644
> --- a/target/s390x/cpu.h
> +++ b/target/s390x/cpu.h
> @@ -76,9 +76,6 @@ struct CPUArchState {
>   
>       float_status fpu_status; /* passed to softfloat lib */
>   
> -    /* The low part of a 128-bit return, or remainder of a divide.  */
> -    uint64_t retxl;
> -

Nice!

Reviewed-by: David Hildenbrand <david@redhat.com>

--
Thanks,

David / dhildenb