Re: [PATCH v5 27/30] tcg/ppc: Remove unused constraint J

[Alex Bennée]

Richard Henderson <richard.henderson@linaro.org> writes:

> Never used since its introduction.
>
> Fixes: 3d582c6179c ("tcg-ppc64: Rearrange integer constant constraints")
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  tcg/ppc/tcg-target-con-str.h | 1 -
>  tcg/ppc/tcg-target.c.inc     | 3 ---
>  2 files changed, 4 deletions(-)
>
> diff --git a/tcg/ppc/tcg-target-con-str.h b/tcg/ppc/tcg-target-con-str.h
> index 9dcbc3df50..094613cbcb 100644
> --- a/tcg/ppc/tcg-target-con-str.h
> +++ b/tcg/ppc/tcg-target-con-str.h
> @@ -16,7 +16,6 @@ REGS('v', ALL_VECTOR_REGS)
>   * CONST(letter, TCG_CT_CONST_* bit set)
>   */
>  CONST('I', TCG_CT_CONST_S16)
> -CONST('J', TCG_CT_CONST_U16)
>  CONST('M', TCG_CT_CONST_MONE)
>  CONST('T', TCG_CT_CONST_S32)
>  CONST('U', TCG_CT_CONST_U32)
> diff --git a/tcg/ppc/tcg-target.c.inc b/tcg/ppc/tcg-target.c.inc
> index 5a4ec0470a..0a14c3e997 100644
> --- a/tcg/ppc/tcg-target.c.inc
> +++ b/tcg/ppc/tcg-target.c.inc
> @@ -83,7 +83,6 @@
>  #define SZR  (TCG_TARGET_REG_BITS / 8)
>  
>  #define TCG_CT_CONST_S16  0x100
> -#define TCG_CT_CONST_U16  0x200

Arguably you could tidy up the bit masks to make it easier to add a
constraint later. But anyway:

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro