Re: [PATCH v4 27/27] target/s390x: Enable TARGET_TB_PCREL

[Thomas Huth]

On 27/02/2023 12.41, Thomas Huth wrote:
> On 21/02/2023 15.35, Thomas Huth wrote:
> > On 20/02/2023 19.40, Richard Henderson wrote:
> > > Reviewed-by: Ilya Leoshkevich <iii@linux.ibm.com>
> > > Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> > > ---
> > >   target/s390x/cpu-param.h     |  4 ++
> > >   target/s390x/cpu.c           | 12 +++++
> > >   target/s390x/tcg/translate.c | 86 +++++++++++++++++++++++-------------
> > >   3 files changed, 71 insertions(+), 31 deletions(-)
...
> FYI, I've unqueued this series from my current pull request again since it's 
> causing trouble with the avocado-system-centos and avocado-system-opensuse 
> CI jobs ... I'll try to pin-point the failing patch later, but since the 
> rest of my current queue is quite long already, I really want to get that 
> big queue merged first.

 Hi Richard,

I've bisected the issue with the failing CI jobs now, and it is indeed this 
last patch here ("Enable TARGET_TB_PCREL") that is causing the failure.

Everything is still green with "Pass original r2 register to BCR":

 https://gitlab.com/thuth/qemu/-/pipelines/794022206

But as soon as I queue "Enable TARGET_TB_PCREL", the avocado jobs start failing:

 https://gitlab.com/thuth/qemu/-/pipelines/793154874

Could you please have a look at the last patch to see what's going wrong here?

... and since soft freeze is approaching: Do you want me to queue the 
remaining patches except the last one, or does the series only make sense as 
a whole?

 Thomas