[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 65/76] target/sparc: Drop get_temp_tl
|
From: |
Richard Henderson |
|
Subject: |
[PATCH v2 65/76] target/sparc: Drop get_temp_tl |
|
Date: |
Sun, 26 Feb 2023 19:24:54 -1000 |
Translators are no longer required to free tcg temporaries,
therefore there's no need to record temps for later freeing.
Replace the few uses with tcg_temp_new.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/sparc/translate.c | 53 ++++++++++++++--------------------------
1 file changed, 18 insertions(+), 35 deletions(-)
diff --git a/target/sparc/translate.c b/target/sparc/translate.c
index 3b0044aa66..2b4af692f6 100644
--- a/target/sparc/translate.c
+++ b/target/sparc/translate.c
@@ -85,9 +85,7 @@ typedef struct DisasContext {
uint32_t cc_op; /* current CC operation */
sparc_def_t *def;
TCGv_i32 t32[3];
- TCGv ttl[5];
int n_t32;
- int n_ttl;
#ifdef TARGET_SPARC64
int fprs_dirty;
int asi;
@@ -139,14 +137,6 @@ static inline TCGv_i32 get_temp_i32(DisasContext *dc)
return t;
}
-static inline TCGv get_temp_tl(DisasContext *dc)
-{
- TCGv t;
- assert(dc->n_ttl < ARRAY_SIZE(dc->ttl));
- dc->ttl[dc->n_ttl++] = t = tcg_temp_new();
- return t;
-}
-
static inline void gen_update_fprs_dirty(DisasContext *dc, int rd)
{
#if defined(TARGET_SPARC64)
@@ -301,7 +291,7 @@ static inline TCGv gen_load_gpr(DisasContext *dc, int reg)
assert(reg < 32);
return cpu_regs[reg];
} else {
- TCGv t = get_temp_tl(dc);
+ TCGv t = tcg_temp_new();
tcg_gen_movi_tl(t, 0);
return t;
}
@@ -321,7 +311,7 @@ static inline TCGv gen_dest_gpr(DisasContext *dc, int reg)
assert(reg < 32);
return cpu_regs[reg];
} else {
- return get_temp_tl(dc);
+ return tcg_temp_new();
}
}
@@ -2897,7 +2887,7 @@ static TCGv get_src2(DisasContext *dc, unsigned int insn)
{
if (IS_IMM) { /* immediate */
target_long simm = GET_FIELDs(insn, 19, 31);
- TCGv t = get_temp_tl(dc);
+ TCGv t = tcg_temp_new();
tcg_gen_movi_tl(t, simm);
return t;
} else { /* register */
@@ -3253,7 +3243,7 @@ static void disas_sparc_insn(DisasContext * dc, unsigned
int insn)
case 2: /* FPU & Logical Operations */
{
unsigned int xop = GET_FIELD(insn, 7, 12);
- TCGv cpu_dst = get_temp_tl(dc);
+ TCGv cpu_dst = tcg_temp_new();
TCGv cpu_tmp0;
if (xop == 0x3a) { /* generate trap */
@@ -3513,7 +3503,7 @@ static void disas_sparc_insn(DisasContext * dc, unsigned
int insn)
if (!supervisor(dc)) {
goto priv_insn;
}
- cpu_tmp0 = get_temp_tl(dc);
+ cpu_tmp0 = tcg_temp_new();
#ifdef TARGET_SPARC64
rs1 = GET_FIELD(insn, 13, 17);
switch (rs1) {
@@ -4031,7 +4021,7 @@ static void disas_sparc_insn(DisasContext * dc, unsigned
int insn)
} else { /* register */
rs2 = GET_FIELD(insn, 27, 31);
cpu_src2 = gen_load_gpr(dc, rs2);
- cpu_tmp0 = get_temp_tl(dc);
+ cpu_tmp0 = tcg_temp_new();
if (insn & (1 << 12)) {
tcg_gen_andi_i64(cpu_tmp0, cpu_src2, 0x3f);
} else {
@@ -4053,7 +4043,7 @@ static void disas_sparc_insn(DisasContext * dc, unsigned
int insn)
} else { /* register */
rs2 = GET_FIELD(insn, 27, 31);
cpu_src2 = gen_load_gpr(dc, rs2);
- cpu_tmp0 = get_temp_tl(dc);
+ cpu_tmp0 = tcg_temp_new();
if (insn & (1 << 12)) {
tcg_gen_andi_i64(cpu_tmp0, cpu_src2, 0x3f);
tcg_gen_shr_i64(cpu_dst, cpu_src1, cpu_tmp0);
@@ -4077,7 +4067,7 @@ static void disas_sparc_insn(DisasContext * dc, unsigned
int insn)
} else { /* register */
rs2 = GET_FIELD(insn, 27, 31);
cpu_src2 = gen_load_gpr(dc, rs2);
- cpu_tmp0 = get_temp_tl(dc);
+ cpu_tmp0 = tcg_temp_new();
if (insn & (1 << 12)) {
tcg_gen_andi_i64(cpu_tmp0, cpu_src2, 0x3f);
tcg_gen_sar_i64(cpu_dst, cpu_src1, cpu_tmp0);
@@ -4263,7 +4253,7 @@ static void disas_sparc_insn(DisasContext * dc, unsigned
int insn)
simm = GET_FIELDs(insn, 20, 31);
tcg_gen_shli_tl(cpu_dst, cpu_src1, simm & 0x1f);
} else { /* register */
- cpu_tmp0 = get_temp_tl(dc);
+ cpu_tmp0 = tcg_temp_new();
tcg_gen_andi_tl(cpu_tmp0, cpu_src2, 0x1f);
tcg_gen_shl_tl(cpu_dst, cpu_src1, cpu_tmp0);
}
@@ -4274,7 +4264,7 @@ static void disas_sparc_insn(DisasContext * dc, unsigned
int insn)
simm = GET_FIELDs(insn, 20, 31);
tcg_gen_shri_tl(cpu_dst, cpu_src1, simm & 0x1f);
} else { /* register */
- cpu_tmp0 = get_temp_tl(dc);
+ cpu_tmp0 = tcg_temp_new();
tcg_gen_andi_tl(cpu_tmp0, cpu_src2, 0x1f);
tcg_gen_shr_tl(cpu_dst, cpu_src1, cpu_tmp0);
}
@@ -4285,7 +4275,7 @@ static void disas_sparc_insn(DisasContext * dc, unsigned
int insn)
simm = GET_FIELDs(insn, 20, 31);
tcg_gen_sari_tl(cpu_dst, cpu_src1, simm & 0x1f);
} else { /* register */
- cpu_tmp0 = get_temp_tl(dc);
+ cpu_tmp0 = tcg_temp_new();
tcg_gen_andi_tl(cpu_tmp0, cpu_src2, 0x1f);
tcg_gen_sar_tl(cpu_dst, cpu_src1, cpu_tmp0);
}
@@ -4294,7 +4284,7 @@ static void disas_sparc_insn(DisasContext * dc, unsigned
int insn)
#endif
case 0x30:
{
- cpu_tmp0 = get_temp_tl(dc);
+ cpu_tmp0 = tcg_temp_new();
switch(rd) {
case 0: /* wry */
tcg_gen_xor_tl(cpu_tmp0, cpu_src1, cpu_src2);
@@ -4479,7 +4469,7 @@ static void disas_sparc_insn(DisasContext * dc, unsigned
int insn)
goto illegal_insn;
}
#else
- cpu_tmp0 = get_temp_tl(dc);
+ cpu_tmp0 = tcg_temp_new();
tcg_gen_xor_tl(cpu_tmp0, cpu_src1, cpu_src2);
gen_helper_wrpsr(cpu_env, cpu_tmp0);
tcg_gen_movi_i32(cpu_cc_op, CC_OP_FLAGS);
@@ -4495,7 +4485,7 @@ static void disas_sparc_insn(DisasContext * dc, unsigned
int insn)
{
if (!supervisor(dc))
goto priv_insn;
- cpu_tmp0 = get_temp_tl(dc);
+ cpu_tmp0 = tcg_temp_new();
tcg_gen_xor_tl(cpu_tmp0, cpu_src1, cpu_src2);
#ifdef TARGET_SPARC64
switch (rd) {
@@ -4653,7 +4643,7 @@ static void disas_sparc_insn(DisasContext * dc, unsigned
int insn)
CHECK_IU_FEATURE(dc, HYPV);
if (!hypervisor(dc))
goto priv_insn;
- cpu_tmp0 = get_temp_tl(dc);
+ cpu_tmp0 = tcg_temp_new();
tcg_gen_xor_tl(cpu_tmp0, cpu_src1, cpu_src2);
switch (rd) {
case 0: // hpstate
@@ -5227,7 +5217,7 @@ static void disas_sparc_insn(DisasContext * dc, unsigned
int insn)
} else if (xop == 0x39) { /* V9 return */
save_state(dc);
cpu_src1 = get_src1(dc, insn);
- cpu_tmp0 = get_temp_tl(dc);
+ cpu_tmp0 = tcg_temp_new();
if (IS_IMM) { /* immediate */
simm = GET_FIELDs(insn, 19, 31);
tcg_gen_addi_tl(cpu_tmp0, cpu_src1, simm);
@@ -5249,7 +5239,7 @@ static void disas_sparc_insn(DisasContext * dc, unsigned
int insn)
#endif
} else {
cpu_src1 = get_src1(dc, insn);
- cpu_tmp0 = get_temp_tl(dc);
+ cpu_tmp0 = tcg_temp_new();
if (IS_IMM) { /* immediate */
simm = GET_FIELDs(insn, 19, 31);
tcg_gen_addi_tl(cpu_tmp0, cpu_src1, simm);
@@ -5344,7 +5334,7 @@ static void disas_sparc_insn(DisasContext * dc, unsigned
int insn)
unsigned int xop = GET_FIELD(insn, 7, 12);
/* ??? gen_address_mask prevents us from using a source
register directly. Always generate a temporary. */
- TCGv cpu_addr = get_temp_tl(dc);
+ TCGv cpu_addr = tcg_temp_new();
tcg_gen_mov_tl(cpu_addr, get_src1(dc, insn));
if (xop == 0x3c || xop == 0x3e) {
@@ -5780,13 +5770,6 @@ static void disas_sparc_insn(DisasContext * dc, unsigned
int insn)
}
dc->n_t32 = 0;
}
- if (dc->n_ttl != 0) {
- int i;
- for (i = dc->n_ttl - 1; i >= 0; --i) {
- tcg_temp_free(dc->ttl[i]);
- }
- dc->n_ttl = 0;
- }
}
static void sparc_tr_init_disas_context(DisasContextBase *dcbase, CPUState *cs)
--
2.34.1
- [PATCH v2 57/76] target/s390x: Use tcg_constant_i32 for fpinst_extract_m34, (continued)
- [PATCH v2 57/76] target/s390x: Use tcg_constant_i32 for fpinst_extract_m34, Richard Henderson, 2023/02/27
- [PATCH v2 59/76] target/s390x: Drop free_compare, Richard Henderson, 2023/02/27
- [PATCH v2 58/76] target/s390x: Use tcg_constant_* in translate_vx.c.inc, Richard Henderson, 2023/02/27
- [PATCH v2 60/76] target/s390x: Drop tcg_temp_free from translate_vx.c.inc, Richard Henderson, 2023/02/27
- [PATCH v2 62/76] target/s390x: Remove assert vs g_in2, Richard Henderson, 2023/02/27
- [PATCH v2 63/76] target/s390x: Remove g_out, g_out2, g_in1, g_in2 from DisasContext, Richard Henderson, 2023/02/27
- [PATCH v2 61/76] target/s390x: Drop tcg_temp_free from translate.c, Richard Henderson, 2023/02/27
- [PATCH v2 67/76] target/sparc: Remove egress label in disas_sparc_context, Richard Henderson, 2023/02/27
- [PATCH v2 69/76] target/sparc: Drop tcg_temp_free, Richard Henderson, 2023/02/27
- [PATCH v2 71/76] target/xtensa: Drop reset_sar_tracker, Richard Henderson, 2023/02/27
- [PATCH v2 65/76] target/sparc: Drop get_temp_tl,
Richard Henderson <=
- [PATCH v2 64/76] target/sh4: Drop tcg_temp_free, Richard Henderson, 2023/02/27
- [PATCH v2 72/76] target/xtensa: Drop tcg_temp_free, Richard Henderson, 2023/02/27
- [PATCH v2 66/76] target/sparc: Drop get_temp_i32, Richard Henderson, 2023/02/27
- [PATCH v2 74/76] tracing: remove transform.py, Richard Henderson, 2023/02/27
- [PATCH v2 75/76] tcg: Create tcg/tcg-temp-internal.h, Richard Henderson, 2023/02/27
- [PATCH v2 76/76] docs/devel/tcg-ops: Drop recommendation to free temps, Richard Henderson, 2023/02/27
- [PATCH v2 68/76] target/sparc: Drop free_compare, Richard Henderson, 2023/02/27
- [PATCH v2 70/76] target/tricore: Drop tcg_temp_free, Richard Henderson, 2023/02/27
- [PATCH v2 73/76] include/exec/gen-icount: Drop tcg_temp_free in gen_tb_start, Richard Henderson, 2023/02/27