[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 13/27] target/s390x: Use ilen instead in branches
From: |
Richard Henderson |
Subject: |
[PATCH v4 13/27] target/s390x: Use ilen instead in branches |
Date: |
Mon, 20 Feb 2023 08:40:38 -1000 |
Remove the remaining uses of pc_tmp, and remove the variable.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Ilya Leoshkevich <iii@linux.ibm.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/s390x/tcg/translate.c | 13 +++----------
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/target/s390x/tcg/translate.c b/target/s390x/tcg/translate.c
index 506bde2c3f..3a61491222 100644
--- a/target/s390x/tcg/translate.c
+++ b/target/s390x/tcg/translate.c
@@ -141,12 +141,6 @@ struct DisasContext {
TCGOp *insn_start;
DisasFields fields;
uint64_t ex_value;
- /*
- * During translate_one(), pc_tmp is used to determine the instruction
- * to be executed after base.pc_next - e.g. next sequential instruction
- * or a branch target.
- */
- uint64_t pc_tmp;
uint32_t ilen;
enum cc_op cc_op;
bool exit_to_mainloop;
@@ -1214,7 +1208,7 @@ static DisasJumpType help_branch(DisasContext *s,
DisasCompare *c,
goto egress;
}
if (is_imm) {
- if (dest == s->pc_tmp) {
+ if (disp == s->ilen) {
/* Branch to next. */
per_branch(s, true);
ret = DISAS_NEXT;
@@ -1238,7 +1232,7 @@ static DisasJumpType help_branch(DisasContext *s,
DisasCompare *c,
}
}
- if (use_goto_tb(s, s->pc_tmp)) {
+ if (use_goto_tb(s, s->base.pc_next + s->ilen)) {
if (is_imm && use_goto_tb(s, dest)) {
/* Both exits can use goto_tb. */
update_cc_op(s);
@@ -6317,7 +6311,6 @@ static const DisasInsn *extract_insn(CPUS390XState *env,
DisasContext *s)
g_assert_not_reached();
}
}
- s->pc_tmp = s->base.pc_next + ilen;
s->ilen = ilen;
/* We can't actually determine the insn format until we've looked up
@@ -6562,7 +6555,7 @@ static DisasJumpType translate_one(CPUS390XState *env,
DisasContext *s)
out:
/* Advance to the next instruction. */
- s->base.pc_next = s->pc_tmp;
+ s->base.pc_next += s->ilen;
return ret;
}
--
2.34.1
- [PATCH v4 00/27] target/s390x: pc-relative translation blocks, Richard Henderson, 2023/02/20
- [PATCH v4 11/27] target/s390x: Use gen_psw_addr_disp in save_link_info, Richard Henderson, 2023/02/20
- [PATCH v4 04/27] target/s390x: Use tcg_constant_* in translate_vx.c.inc, Richard Henderson, 2023/02/20
- [PATCH v4 03/27] target/s390x: Use tcg_constant_i32 for fpinst_extract_m34, Richard Henderson, 2023/02/20
- [PATCH v4 13/27] target/s390x: Use ilen instead in branches,
Richard Henderson <=
- [PATCH v4 14/27] target/s390x: Assert masking of psw.addr in cpu_get_tb_cpu_state, Richard Henderson, 2023/02/20
- [PATCH v4 08/27] target/s390x: Introduce gen_psw_addr_disp, Richard Henderson, 2023/02/20
- [PATCH v4 06/27] tests/tcg/s390x: Add sam.S, Richard Henderson, 2023/02/20
- [PATCH v4 15/27] target/s390x: Add disp argument to update_psw_addr, Richard Henderson, 2023/02/20
- [PATCH v4 16/27] target/s390x: Don't set gbea for user-only, Richard Henderson, 2023/02/20
- [PATCH v4 07/27] target/s390x: Change help_goto_direct to work on displacements, Richard Henderson, 2023/02/20
- [PATCH v4 05/27] tests/tcg/s390x: Add bal.S, Richard Henderson, 2023/02/20
- [PATCH v4 01/27] target/s390x: Use tcg_constant_* in local contexts, Richard Henderson, 2023/02/20
- [PATCH v4 09/27] target/s390x: Remove pc argument to pc_to_link_into, Richard Henderson, 2023/02/20
- [PATCH v4 18/27] target/s390x: Disable conditional branch-to-next for PER, Richard Henderson, 2023/02/20