[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 2/5] migration/block: Convert remaining DPRINTF() debug macro to t
From: |
Juan Quintela |
Subject: |
[PULL 2/5] migration/block: Convert remaining DPRINTF() debug macro to trace events |
Date: |
Wed, 15 Feb 2023 21:05:51 +0100 |
From: Philippe Mathieu-Daudé <philmd@linaro.org>
Finish the conversion from commit fe80c0241d
("migration: using trace_ to replace DPRINTF").
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
migration/block.c | 12 +-----------
migration/trace-events | 1 +
2 files changed, 2 insertions(+), 11 deletions(-)
diff --git a/migration/block.c b/migration/block.c
index 29f69025af..b5ce506d01 100644
--- a/migration/block.c
+++ b/migration/block.c
@@ -42,16 +42,6 @@
#define MAX_IO_BUFFERS 512
#define MAX_PARALLEL_IO 16
-/* #define DEBUG_BLK_MIGRATION */
-
-#ifdef DEBUG_BLK_MIGRATION
-#define DPRINTF(fmt, ...) \
- do { printf("blk_migration: " fmt, ## __VA_ARGS__); } while (0)
-#else
-#define DPRINTF(fmt, ...) \
- do { } while (0)
-#endif
-
typedef struct BlkMigDevState {
/* Written during setup phase. Can be read without a lock. */
BlockBackend *blk;
@@ -502,7 +492,7 @@ static int blk_mig_save_bulked_block(QEMUFile *f)
block_mig_state.prev_progress = progress;
qemu_put_be64(f, (progress << BDRV_SECTOR_BITS)
| BLK_MIG_FLAG_PROGRESS);
- DPRINTF("Completed %d %%\r", progress);
+ trace_migration_block_progression(progress);
}
return ret;
diff --git a/migration/trace-events b/migration/trace-events
index 67b65a70ff..b20e1271bc 100644
--- a/migration/trace-events
+++ b/migration/trace-events
@@ -357,6 +357,7 @@ migration_block_flush_blks(const char *action, int
submitted, int read_done, int
migration_block_save(const char *mig_stage, int submitted, int transferred)
"Enter save live %s submitted %d transferred %d"
migration_block_save_complete(void) "Block migration completed"
migration_block_state_pending(uint64_t pending) "Enter save live pending %"
PRIu64
+migration_block_progression(unsigned percent) "Completed %u%%"
# page_cache.c
migration_pagecache_init(int64_t max_num_items) "Setting cache buckets to %"
PRId64
--
2.39.1
- [PULL 0/5] Migration 20230215 patches, Juan Quintela, 2023/02/15
- [PULL 1/5] migration/qemu-file: Add qemu_file_get_to_fd(), Juan Quintela, 2023/02/15
- [PULL 2/5] migration/block: Convert remaining DPRINTF() debug macro to trace events,
Juan Quintela <=
- [PULL 3/5] migration: In case of postcopy, the memory ends in res_postcopy_only, Juan Quintela, 2023/02/15
- [PULL 4/5] migration: Remove unused res_compatible, Juan Quintela, 2023/02/15
- [PULL 5/5] migration: Rename res_{postcopy,precopy}_only, Juan Quintela, 2023/02/15
- Re: [PULL 0/5] Migration 20230215 patches, Peter Maydell, 2023/02/16