[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 17/21] gdbstub: fix address type of gdb_set_cpu_pc
From: |
Alex Bennée |
Subject: |
[PATCH v2 17/21] gdbstub: fix address type of gdb_set_cpu_pc |
Date: |
Thu, 5 Jan 2023 16:43:16 +0000 |
The underlying call uses vaddr and the comms API uses unsigned long
long which will always fit. We don't need to deal in target_ulong
here.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
gdbstub/gdbstub.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c
index c293b8e43c..4547ca3367 100644
--- a/gdbstub/gdbstub.c
+++ b/gdbstub/gdbstub.c
@@ -535,7 +535,7 @@ static void gdb_process_breakpoint_remove_all(GDBProcess *p)
}
-static void gdb_set_cpu_pc(target_ulong pc)
+static void gdb_set_cpu_pc(vaddr pc)
{
CPUState *cpu = gdbserver_state.c_cpu;
@@ -1289,7 +1289,7 @@ static void handle_file_io(GArray *params, void *user_ctx)
static void handle_step(GArray *params, void *user_ctx)
{
if (params->len) {
- gdb_set_cpu_pc((target_ulong)get_param(params, 0)->val_ull);
+ gdb_set_cpu_pc(get_param(params, 0)->val_ull);
}
cpu_single_step(gdbserver_state.c_cpu, gdbserver_state.sstep_flags);
--
2.34.1
- [PATCH v2 09/21] gdbstub: make various helpers visible to the rest of the module, (continued)
- [PATCH v2 09/21] gdbstub: make various helpers visible to the rest of the module, Alex Bennée, 2023/01/05
- [PATCH v2 12/21] gdbstub: abstract target specific details from gdb_put_packet_binary, Alex Bennée, 2023/01/05
- [PATCH v2 13/21] gdbstub: specialise handle_query_attached, Alex Bennée, 2023/01/05
- [PATCH v2 21/21] gdbstub: only compile gdbstub twice for whole build, Alex Bennée, 2023/01/05
- [PATCH v2 14/21] gdbstub: specialise target_memory_rw_debug, Alex Bennée, 2023/01/05
- [PATCH v2 11/21] gdbstub: move chunks of user code into own files, Alex Bennée, 2023/01/05
- [PATCH v2 10/21] gdbstub: move chunk of softmmu functionality to own file, Alex Bennée, 2023/01/05
- [PATCH v2 17/21] gdbstub: fix address type of gdb_set_cpu_pc,
Alex Bennée <=
- [PATCH v2 16/21] gdbstub: specialise stub_can_reverse, Alex Bennée, 2023/01/05
- [PATCH v2 18/21] gdbstub: don't use target_ulong while handling registers, Alex Bennée, 2023/01/05
- [PATCH v2 15/21] gdbstub: introduce gdb_get_max_cpus, Alex Bennée, 2023/01/05
- [PATCH v2 19/21] gdbstub: move register helpers into standalone include, Alex Bennée, 2023/01/05