[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 14/27] target/s390x: Assert masking of psw.addr in cpu_get
|
From: |
Ilya Leoshkevich |
|
Subject: |
Re: [PATCH v2 14/27] target/s390x: Assert masking of psw.addr in cpu_get_tb_cpu_state |
|
Date: |
Tue, 13 Dec 2022 18:14:16 +0100 |
On Sun, Dec 11, 2022 at 09:27:49AM -0600, Richard Henderson wrote:
> When changing modes via SAM, we raise a specification exception if the
> new PC is out of range. The masking in s390x_tr_init_disas_context
> was too late to be correct, but may be removed. Add a debugging
> assert in cpu_get_tb_cpu_state.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/s390x/cpu.h | 20 ++++++++++++++------
> target/s390x/tcg/translate.c | 6 +-----
> 2 files changed, 15 insertions(+), 11 deletions(-)
Reviewed-by: Ilya Leoshkevich <iii@linux.ibm.com>
- Re: [PATCH v2 02/27] target/s390x: Use tcg_constant_* for DisasCompare, (continued)
- [PATCH v2 05/27] tests/tcg/s390x: Add bal.S, Richard Henderson, 2022/12/11
- [PATCH v2 11/27] target/s390x: Use gen_psw_addr_disp in save_link_info, Richard Henderson, 2022/12/11
- [PATCH v2 07/27] target/s390x: Change help_goto_direct to work on displacements, Richard Henderson, 2022/12/11
- [PATCH v2 16/27] target/s390x: Don't set gbea for user-only, Richard Henderson, 2022/12/11
- [PATCH v2 18/27] target/s390x: Disable conditional branch-to-next for PER, Richard Henderson, 2022/12/11
- [PATCH v2 13/27] target/s390x: Use ilen instead in branches, Richard Henderson, 2022/12/11
- [PATCH v2 14/27] target/s390x: Assert masking of psw.addr in cpu_get_tb_cpu_state, Richard Henderson, 2022/12/11
- Re: [PATCH v2 14/27] target/s390x: Assert masking of psw.addr in cpu_get_tb_cpu_state,
Ilya Leoshkevich <=
- [PATCH v2 15/27] target/s390x: Add disp argument to update_psw_addr, Richard Henderson, 2022/12/11
- [PATCH v2 09/27] target/s390x: Remove pc argument to pc_to_link_into, Richard Henderson, 2022/12/11
- [PATCH v2 17/27] target/s390x: Introduce per_enabled, Richard Henderson, 2022/12/11
- [PATCH v2 08/27] target/s390x: Introduce gen_psw_addr_disp, Richard Henderson, 2022/12/11
- [PATCH v2 10/27] target/s390x: Use gen_psw_addr_disp in pc_to_link_info, Richard Henderson, 2022/12/11
- [PATCH v2 12/27] target/s390x: Use gen_psw_addr_disp in op_sam, Richard Henderson, 2022/12/11
- [PATCH v2 19/27] target/s390x: Introduce help_goto_indirect, Richard Henderson, 2022/12/11