[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-8.0] target/s390x: The MVCP and MVCS instructions are not
|
From: |
Ilya Leoshkevich |
|
Subject: |
Re: [PATCH for-8.0] target/s390x: The MVCP and MVCS instructions are not privileged |
|
Date: |
Tue, 06 Dec 2022 12:43:57 +0100 |
|
User-agent: |
Evolution 3.46.1 (3.46.1-1.fc37) |
On Mon, 2022-12-05 at 13:58 +0100, Thomas Huth wrote:
> The "MOVE TO PRIMARY/SECONDARY" instructions can also be called
> from problem state. We just should properly check whether the
> secondary-space access key is valid here, too, and inject a
> privileged program exception if it is invalid.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> Found only by code inspection - I'm not aware yet of any problem
> in the wild due to this bug.
>
> target/s390x/helper.h | 4 ++--
> target/s390x/tcg/insn-data.h.inc | 4 ++--
> target/s390x/tcg/mem_helper.c | 16 ++++++++++++----
> target/s390x/tcg/translate.c | 6 ++++--
> 4 files changed, 20 insertions(+), 10 deletions(-)
Reviewed-by: Ilya Leoshkevich <iii@linux.ibm.com>