Re: [PATCH 3/3] target/tricore: Rename csfr.def -> csfr.h.inc

[Laurent Vivier]

Le 26/10/2022 à 01:50, Philippe Mathieu-Daudé a écrit :
> We use the .h.inc extension to include C headers. To be consistent
> with the rest of the codebase, rename the C headers using the .def
> extension.
>
> IDE/tools using our .editorconfig / .gitattributes will leverage
> this consistency.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   target/tricore/{csfr.def => csfr.h.inc} | 0
>   target/tricore/translate.c              | 4 ++--
>   2 files changed, 2 insertions(+), 2 deletions(-)
>   rename target/tricore/{csfr.def => csfr.h.inc} (100%)
>
> diff --git a/target/tricore/csfr.def b/target/tricore/csfr.h.inc
> similarity index 100%
> rename from target/tricore/csfr.def
> rename to target/tricore/csfr.h.inc
> diff --git a/target/tricore/translate.c b/target/tricore/translate.c
> index a0558ead71..f02090945d 100644
> --- a/target/tricore/translate.c
> +++ b/target/tricore/translate.c
> @@ -388,7 +388,7 @@ static inline void gen_mfcr(DisasContext *ctx, TCGv ret, 
> int32_t offset)
>           gen_helper_psw_read(ret, cpu_env);
>       } else {
>           switch (offset) {
> -#include "csfr.def"
> +#include "csfr.h.inc"
>           }
>       }
>   }
> @@ -418,7 +418,7 @@ static inline void gen_mtcr(DisasContext *ctx, TCGv r1,
>               gen_helper_psw_write(cpu_env, r1);
>           } else {
>               switch (offset) {
> -#include "csfr.def"
> +#include "csfr.h.inc"
>               }
>           }
>       } else {

Applied to my trivial-patches branch.

Thanks,
Laurent