Re: [PATCH v8 0/8] s390x/pci: zPCI interpretation support

[Thomas Huth]

On 02/09/2022 19.27, Matthew Rosato wrote:
> Now that the kernel series [1] is merged and the freeze is over, here is a
> refresh of the zPCI interpretation series.
>                                                             
> For QEMU, the majority of the work in enabling instruction interpretation
> is handled via SHM bit settings (to indicate to firmware whether or not
> interpretive execution facilities are to be used) + a new KVM ioctl is
> used to setup firmware-interpreted forwarding of Adapter Event
> Notifications.
>
> This series also adds a new, optional 'interpret' parameter to zpci which
> can be used to disable interpretation support (interpret=off) as well as
> an 'forwarding_assist' parameter to determine whether or not the firmware
> assist will be used for adapter event delivery (default when
> interpretation is in use) or whether the host will be responsible for
> delivering all adapter event notifications (forwarding_assist=off).
>
> The zpcii-disable machine property is added to allow disabling use of
> zPCI interpretation facilities for a guest. This property is set to on
> for older (pre-7.2 compat machines), but defaults to off for 7.2 and
> newer. This allows newer machines to use interpretation by default if
> the necessary kernel interfaces and hardware facilities are available,
> but also provides a mechanism for disabling interpretation completely
> for debug purposes.
>
> As a consequence of implementing zPCI interpretation, ISM devices now
> become eligible for passthrough (but only when zPCI interpretation is
> available).
>
>  From the perspective of guest configuration, you passthrough zPCI devices
> in the same manner as before, with intepretation support being used by
> default if available in kernel+qemu.
>
> Changelog v7->v8:
> - Rebase onto 7.1.0
> - Move compat machine changes for patch 8
> - Refresh kernel header sync to 6.0-rc3
>
> [1] https://lore.kernel.org/kvm/20220606203325.110625-1-mjrosato@linux.ibm.com/
>
> Matthew Rosato (8):
>    linux-headers: update to 6.0-rc3
>    s390x/pci: add routine to get host function handle from CLP info
>    s390x/pci: enable for load/store intepretation

Typo in that subject, should be "interpretation" instead of "intepretation".

>    s390x/pci: don't fence interpreted devices without MSI-X
>    s390x/pci: enable adapter event notification for interpreted devices
>    s390x/pci: let intercept devices have separate PCI groups
>    s390x/pci: reflect proper maxstbl for groups of interpreted devices
>    s390x/s390-virtio-ccw: add zpcii-disable machine property

Thanks, patch series looks basically fine to me now. Some nits here and 
there, so if you could still fix those up and send a v9, that would be 
great! (If you are completely out of spare time for that, let me know, then 
I can also try to fix those up on my own when picking up the patches)

 Thomas