[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/9] exec/hwaddr.h: Add missing include
From: |
Bernhard Beschow |
Subject: |
Re: [PATCH 2/9] exec/hwaddr.h: Add missing include |
Date: |
Tue, 20 Sep 2022 23:03:49 +0000 |
Am 20. September 2022 04:50:51 UTC schrieb "Philippe Mathieu-Daudé"
<f4bug@amsat.org>:
>On 20/9/22 01:17, Bernhard Beschow wrote:
>> The next commit would not compile w/o the include directive.
>>
>> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
>> ---
>> include/exec/hwaddr.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/include/exec/hwaddr.h b/include/exec/hwaddr.h
>> index 8f16d179a8..616255317c 100644
>> --- a/include/exec/hwaddr.h
>> +++ b/include/exec/hwaddr.h
>> @@ -3,6 +3,7 @@
>> #ifndef HWADDR_H
>> #define HWADDR_H
>> +#include "qemu/osdep.h"
>
>NAck: This is an anti-pattern. "qemu/osdep.h" must not be included
>in .h, only in .c.
>
>Isn't including "hw/qdev-core.h" in "include/hw/boards.h" enough in
>the next patch?
Yes, this works just fine indeed! This patch could be dropped if in the next
iteration, if any.
Thanks,
Bernhard
Re: [PATCH 1/9] hw/riscv/sifive_e: Fix inheritance of SiFiveEState, Philippe Mathieu-Daudé, 2022/09/20
[PATCH 2/9] exec/hwaddr.h: Add missing include, Bernhard Beschow, 2022/09/19
[PATCH 3/9] hw/core/sysbus: Resolve main_system_bus singleton, Bernhard Beschow, 2022/09/19
[PATCH 4/9] hw/ppc/spapr: Fix code style problems reported by checkpatch, Bernhard Beschow, 2022/09/19
[PATCH 5/9] exec/address-spaces: Wrap address space singletons into functions, Bernhard Beschow, 2022/09/19
[PATCH 6/9] target/loongarch/cpu: Remove unneeded include directive, Bernhard Beschow, 2022/09/19
[PATCH 7/9] hw/sysbus: Introduce dedicated struct SysBusState for TYPE_SYSTEM_BUS, Bernhard Beschow, 2022/09/19
[PATCH 8/9] softmmu/physmem: Let SysBusState absorb memory region and address space singletons, Bernhard Beschow, 2022/09/19