[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] target/s390x: Align __excp_addr in s390_probe_access
|
From: |
David Hildenbrand |
|
Subject: |
Re: [PATCH 2/2] target/s390x: Align __excp_addr in s390_probe_access |
|
Date: |
Wed, 24 Aug 2022 09:34:26 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 |
On 23.08.22 23:38, Richard Henderson wrote:
> Per the comment in s390_cpu_record_sigsegv, the saved address
> is always page aligned.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/s390x/tcg/mem_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/s390x/tcg/mem_helper.c b/target/s390x/tcg/mem_helper.c
> index 4c0f8baa39..19ea7d2f8d 100644
> --- a/target/s390x/tcg/mem_helper.c
> +++ b/target/s390x/tcg/mem_helper.c
> @@ -147,7 +147,7 @@ static int s390_probe_access(CPUArchState *env,
> target_ulong addr, int size,
> #if defined(CONFIG_USER_ONLY)
> flags = page_get_flags(addr);
> if (!(flags & (access_type == MMU_DATA_LOAD ? PAGE_READ :
> PAGE_WRITE_ORG))) {
> - env->__excp_addr = addr;
> + env->__excp_addr = addr & TARGET_PAGE_MASK;
> flags = (flags & PAGE_VALID) ? PGM_PROTECTION : PGM_ADDRESSING;
> if (nonfault) {
> return flags;
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb