[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 1/4] accel/tcg: Invalidate translations when clearing PAGE
|
From: |
Ilya Leoshkevich |
|
Subject: |
Re: [PATCH v3 1/4] accel/tcg: Invalidate translations when clearing PAGE_EXEC |
|
Date: |
Fri, 12 Aug 2022 17:02:41 +0200 |
|
User-agent: |
Evolution 3.42.4 (3.42.4-2.fc35) |
On Thu, 2022-08-11 at 08:42 -0700, Richard Henderson wrote:
> On 8/11/22 02:28, Ilya Leoshkevich wrote:
> > How is qemu-user's get_page_addr_code() involved here?
> >
> > I tried to experiment with it, and while I agree that it looks
> > buggy,
> > it's called only from translation code paths. If we already have a
> > translation block, these code paths are not used.
>
> It's called from tb_lookup too, when we're trying to find an existing
> TB.
>
>
> r~
>
Oh, I see. I was first worried about direct block chaining with
goto_tb, but it turned out that translator_use_goto_tb() prevented it.
tb_lookup() skips get_page_addr_code() if tb is found in tb_jmp_cache.
I assume it's a bug?
[PATCH v3 4/4] tests/tcg: Test siginfo_t contents when jumping to non-readable pages, Ilya Leoshkevich, 2022/08/08
[PATCH v3 2/4] target/s390x: Make translator stop before the end of a page, Ilya Leoshkevich, 2022/08/08
[PATCH v3 3/4] target/i386: Make translator stop before the end of a page, Ilya Leoshkevich, 2022/08/08