[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 10/18] dump: Reorder struct DumpState
From: |
Janosch Frank |
Subject: |
[PATCH v5 10/18] dump: Reorder struct DumpState |
Date: |
Thu, 11 Aug 2022 12:11:03 +0000 |
Let's move ELF related members into one block and guest memory related
ones into another to improve readability.
Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
include/sysemu/dump.h | 16 +++++++++-------
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/include/sysemu/dump.h b/include/sysemu/dump.h
index 9995f65dc8..9ed811b313 100644
--- a/include/sysemu/dump.h
+++ b/include/sysemu/dump.h
@@ -154,15 +154,8 @@ typedef struct DumpState {
GuestPhysBlockList guest_phys_blocks;
ArchDumpInfo dump_info;
MemoryMappingList list;
- uint32_t phdr_num;
- uint32_t shdr_num;
bool resume;
bool detached;
- ssize_t note_size;
- hwaddr shdr_offset;
- hwaddr phdr_offset;
- hwaddr section_offset;
- hwaddr note_offset;
hwaddr memory_offset;
int fd;
@@ -177,6 +170,15 @@ typedef struct DumpState {
int64_t filter_area_begin; /* Start address of partial guest memory area
*/
int64_t filter_area_length; /* Length of partial guest memory area */
+ /* Elf dump related data */
+ uint32_t phdr_num;
+ uint32_t shdr_num;
+ ssize_t note_size;
+ hwaddr shdr_offset;
+ hwaddr phdr_offset;
+ hwaddr section_offset;
+ hwaddr note_offset;
+
void *elf_section_hdrs; /* Pointer to section header buffer */
uint8_t *note_buf; /* buffer for notes */
--
2.34.1
- [PATCH v5 00/18] dump: Add arch section and s390x PV dump, Janosch Frank, 2022/08/11
- [PATCH v5 05/18] dump: Rework filter area variables, Janosch Frank, 2022/08/11
- [PATCH v5 03/18] dump: Refactor dump_iterate and introduce dump_filter_memblock_*(), Janosch Frank, 2022/08/11
- [PATCH v5 09/18] dump: Use a buffer for ELF section data and headers, Janosch Frank, 2022/08/11
- [PATCH v5 10/18] dump: Reorder struct DumpState,
Janosch Frank <=
- [PATCH v5 15/18] s390x: Add protected dump cap, Janosch Frank, 2022/08/11
- [PATCH v5 14/18] DRAFT: linux header sync, Janosch Frank, 2022/08/11
- [PATCH v5 16/18] s390x: Introduce PV query interface, Janosch Frank, 2022/08/11
- [PATCH v5 17/18] s390x: Add KVM PV dump interface, Janosch Frank, 2022/08/11
- [PATCH v5 18/18] s390x: pv: Add dump support, Janosch Frank, 2022/08/11