[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 06/14] dump: Reorder struct DumpState
From: |
Janosch Frank |
Subject: |
[PATCH v3 06/14] dump: Reorder struct DumpState |
Date: |
Thu, 21 Jul 2022 13:22:48 +0000 |
Let's move ELF related members into one block and guest memory related
ones into another to improve readability.
Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
---
include/sysemu/dump.h | 17 ++++++++++-------
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/include/sysemu/dump.h b/include/sysemu/dump.h
index dad10dee0b..a94d81303d 100644
--- a/include/sysemu/dump.h
+++ b/include/sysemu/dump.h
@@ -154,15 +154,8 @@ typedef struct DumpState {
GuestPhysBlockList guest_phys_blocks;
ArchDumpInfo dump_info;
MemoryMappingList list;
- uint32_t phdr_num;
- uint32_t shdr_num;
bool resume;
bool detached;
- ssize_t note_size;
- hwaddr shdr_offset;
- hwaddr phdr_offset;
- hwaddr section_offset;
- hwaddr note_offset;
hwaddr memory_offset;
int fd;
@@ -171,6 +164,16 @@ typedef struct DumpState {
int64_t begin; /* Start address of the chunk we want to dump */
int64_t length; /* Length of the dump we want to dump */
+ /* Elf dump related data */
+ uint32_t phdr_num;
+ uint32_t shdr_num;
+ uint32_t sh_info;
+ ssize_t note_size;
+ hwaddr shdr_offset;
+ hwaddr phdr_offset;
+ hwaddr note_offset;
+ hwaddr section_offset;
+
void *elf_header;
void *elf_section_hdrs;
uint64_t elf_section_data_size;
--
2.34.1
- [PATCH v3 02/14] dump: Rename write_elf_loads to write_elf_phdr_loads, (continued)
- [PATCH v3 02/14] dump: Rename write_elf_loads to write_elf_phdr_loads, Janosch Frank, 2022/07/21
- [PATCH v3 03/14] dump: Convert GuestPhysBlock iterators and use the filter functions, Janosch Frank, 2022/07/21
- [PATCH v3 04/14] dump: Allocate header, Janosch Frank, 2022/07/21
- [PATCH v3 05/14] dump: Split write of section headers and data and add a prepare step, Janosch Frank, 2022/07/21
- [PATCH v3 06/14] dump: Reorder struct DumpState,
Janosch Frank <=
- [PATCH v3 07/14] dump: Swap segment and section header locations, Janosch Frank, 2022/07/21
- [PATCH v3 08/14] dump/dump: Add section string table support, Janosch Frank, 2022/07/21
- [PATCH v3 09/14] dump/dump: Add arch section support, Janosch Frank, 2022/07/21
- [PATCH v3 11/14] s390x: Add protected dump cap, Janosch Frank, 2022/07/21
- [PATCH v3 12/14] s390x: Introduce PV query interface, Janosch Frank, 2022/07/21