|
From: | Richard Henderson |
Subject: | Re: [PATCH 1/3] target/s390x: fix handling of zeroes in vfmin/vfmax |
Date: | Tue, 12 Jul 2022 09:53:23 +0530 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 |
On 7/12/22 07:27, Ilya Leoshkevich wrote:
vfmin_res() / vfmax_res() are trying to check whether a and b are both zeroes, but in reality they check that they are the same kind of zero. This causes incorrect results when comparing positive and negative zeroes. Fixes: da4807527f3b ("s390x/tcg: Implement VECTOR FP (MAXIMUM|MINIMUM)") Co-developed-by: Ulrich Weigand<ulrich.weigand@de.ibm.com> Signed-off-by: Ilya Leoshkevich<iii@linux.ibm.com> --- target/s390x/tcg/vec_fpu_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
[Prev in Thread] | Current Thread | [Next in Thread] |