[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 09/18] pc-bios/s390-ccw/virtio: Beautify the code for reading virt
From: |
Thomas Huth |
Subject: |
[PULL 09/18] pc-bios/s390-ccw/virtio: Beautify the code for reading virtqueue configuration |
Date: |
Thu, 7 Jul 2022 09:54:17 +0200 |
It looks nicer if we separate the run_ccw() from the IPL_assert()
statement, and the error message should talk about "virtio device"
instead of "block device", since this code is nowadays used for
non-block (i.e. network) devices, too.
Message-Id: <20220704111903.62400-9-thuth@redhat.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Eric Farman <farman@linux.ibm.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
pc-bios/s390-ccw/virtio.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/pc-bios/s390-ccw/virtio.c b/pc-bios/s390-ccw/virtio.c
index d8c2b52710..f37510f312 100644
--- a/pc-bios/s390-ccw/virtio.c
+++ b/pc-bios/s390-ccw/virtio.c
@@ -289,9 +289,8 @@ void virtio_setup_ccw(VDev *vdev)
.num = 0,
};
- IPL_assert(
- run_ccw(vdev, CCW_CMD_READ_VQ_CONF, &config, sizeof(config),
false) == 0,
- "Could not get block device VQ configuration");
+ rc = run_ccw(vdev, CCW_CMD_READ_VQ_CONF, &config, sizeof(config),
false);
+ IPL_assert(rc == 0, "Could not get virtio device VQ configuration");
info.num = config.num;
vring_init(&vdev->vrings[i], &info);
vdev->vrings[i].schid = vdev->schid;
--
2.31.1
- [PULL 00/18] s390x updates, Thomas Huth, 2022/07/07
- [PULL 03/18] pc-bios/s390-ccw/virtio: Introduce a macro for the DASD block size, Thomas Huth, 2022/07/07
- [PULL 02/18] pc-bios/s390-ccw: Add a proper prototype for main(), Thomas Huth, 2022/07/07
- [PULL 06/18] pc-bios/s390-ccw/virtio-blkdev: Remove virtio_assume_scsi(), Thomas Huth, 2022/07/07
- [PULL 08/18] pc-bios/s390-ccw/virtio: Read device config after feature negotiation, Thomas Huth, 2022/07/07
- [PULL 13/18] pc-bios/s390-ccw/netboot.mak: Ignore Clang's warnings about GNU extensions, Thomas Huth, 2022/07/07
- [PULL 10/18] pc-bios/s390-ccw: Split virtio-scsi code from virtio_blk_setup_device(), Thomas Huth, 2022/07/07
- [PULL 04/18] pc-bios/s390-ccw/bootmap: Improve the guessing logic in zipl_load_vblk(), Thomas Huth, 2022/07/07
- [PULL 05/18] pc-bios/s390-ccw/virtio-blkdev: Simplify/fix virtio_ipl_disk_is_valid(), Thomas Huth, 2022/07/07
- [PULL 07/18] pc-bios/s390-ccw/virtio: Set missing status bits while initializing, Thomas Huth, 2022/07/07
- [PULL 09/18] pc-bios/s390-ccw/virtio: Beautify the code for reading virtqueue configuration,
Thomas Huth <=
- [PULL 01/18] target/s390x/tcg: SPX: check validity of new prefix, Thomas Huth, 2022/07/07
- [PULL 12/18] pc-bios/s390-ccw/virtio: Remove "extern" keyword from prototypes, Thomas Huth, 2022/07/07
- [PULL 15/18] target/s390x: Remove DISAS_GOTO_TB, Thomas Huth, 2022/07/07
- [PULL 11/18] pc-bios/s390-ccw/virtio-blkdev: Request the right feature bits, Thomas Huth, 2022/07/07
- [PULL 18/18] target/s390x: Exit tb after executing ex_value, Thomas Huth, 2022/07/07
- [PULL 17/18] target/s390x: Remove DISAS_PC_STALE_NOCHAIN, Thomas Huth, 2022/07/07
- [PULL 14/18] pc-bios/s390-ccw: Update the s390-ccw bios binaries with the virtio-blk fixes, Thomas Huth, 2022/07/07
- [PULL 16/18] target/s390x: Remove DISAS_PC_STALE, Thomas Huth, 2022/07/07
- Re: [PULL 00/18] s390x updates, Richard Henderson, 2022/07/07