Re: [PATCH 3/4] virtio-ccw: move device type declarations to .c files

[Halil Pasic]

On Mon, 28 Mar 2022 16:30:18 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Just curious: is device type declarations for
leaf device types should be private a best practice in QEMU?

> ---
>  hw/s390x/s390-virtio-ccw.c    |   1 +
>  hw/s390x/vhost-scsi-ccw.c     |   9 +++
>  hw/s390x/vhost-vsock-ccw.c    |   9 +++
>  hw/s390x/virtio-ccw-9p.c      |   9 +++
>  hw/s390x/virtio-ccw-balloon.c |   9 +++
>  hw/s390x/virtio-ccw-blk.c     |   9 +++
>  hw/s390x/virtio-ccw-crypto.c  |   9 +++
>  hw/s390x/virtio-ccw-gpu.c     |   9 +++
>  hw/s390x/virtio-ccw-input.c   |  20 +++++
>  hw/s390x/virtio-ccw-net.c     |   9 +++
>  hw/s390x/virtio-ccw-rng.c     |   9 +++
>  hw/s390x/virtio-ccw-scsi.c    |   9 +++
>  hw/s390x/virtio-ccw-serial.c  |   9 +++
>  hw/s390x/virtio-ccw.c         |   2 +
>  hw/s390x/virtio-ccw.h         | 133 ----------------------------------
>  15 files changed, 122 insertions(+), 133 deletions(-)
> 
> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
> index 90480e7cf9..2d32647d08 100644
> --- a/hw/s390x/s390-virtio-ccw.c
> +++ b/hw/s390x/s390-virtio-ccw.c
> @@ -25,6 +25,7 @@
>  #include "qemu/error-report.h"
>  #include "qemu/option.h"
>  #include "qemu/qemu-print.h"
> +#include "qemu/units.h"

Unrelated?

[..]
> diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c
> index c845a92c3a..15b458527e 100644
> --- a/hw/s390x/virtio-ccw.c
> +++ b/hw/s390x/virtio-ccw.c
> @@ -12,6 +12,7 @@
>  
>  #include "qemu/osdep.h"
>  #include "qapi/error.h"
> +#include "exec/address-spaces.h"

Unrelated?

>  #include "sysemu/kvm.h"
>  #include "net/net.h"
>  #include "hw/virtio/virtio.h"
> @@ -19,6 +20,7 @@
>  #include "hw/virtio/virtio-net.h"
>  #include "qemu/bitops.h"
>  #include "qemu/error-report.h"
> +#include "qemu/log.h"

Unrelated?

Reviewed-by: Halil Pasic <pasic@linux.ibm.com>