Re: [PATCH v4 14/22] qapi: introduce x-query-rdma QMP command

[Philippe Mathieu-Daudé]

On 10/28/21 17:54, Daniel P. Berrangé wrote:
> This is a counterpart to the HMP "info rdma" command. It is being
> added with an "x-" prefix because this QMP command is intended as an
> adhoc debugging tool and will thus not be modelled in QAPI as fully
> structured data, nor will it have long term guaranteed stability.
> The existing HMP command is rewritten to call the QMP command.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  hmp-commands-info.hx      |   2 +-
>  hw/rdma/rdma_rm.c         | 104 +++++++++++++++++++-------------------
>  hw/rdma/rdma_rm.h         |   2 +-
>  hw/rdma/vmw/pvrdma_main.c |  31 ++++++------
>  include/hw/rdma/rdma.h    |   2 +-
>  monitor/hmp-cmds.c        |  27 ----------
>  monitor/qmp-cmds.c        |  32 ++++++++++++
>  qapi/machine.json         |  12 +++++
>  8 files changed, 115 insertions(+), 97 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>