[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] target/s390x: Optimize save_link_info() using extract() TCG
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH] target/s390x: Optimize save_link_info() using extract() TCG opcode |
|
Date: |
Sun, 3 Oct 2021 17:51:24 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 |
On 10/3/21 17:31, Richard Henderson wrote:
> On 10/3/21 10:29 AM, Philippe Mathieu-Daudé wrote:
>> - tcg_gen_shri_i64(t, psw_mask, 16);
>> - tcg_gen_andi_i64(t, t, 0x0f000000);
>> + tcg_gen_extract_i64(t, psw_mask, 40, 4);
>
> No, the result should not be at bit 0, but bit 24.
Good catch. I was no sure about that one, should have tagged RFC.
Thanks for the multiple reviews!