[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v12 07/16] qtest/numa-test: Use detailed -smp CLIs in pc_dynamic_
From: |
Yanan Wang |
Subject: |
[PATCH v12 07/16] qtest/numa-test: Use detailed -smp CLIs in pc_dynamic_cpu_cfg |
Date: |
Wed, 29 Sep 2021 10:58:07 +0800 |
Since commit 80d7835749 (qemu-options: rewrite help for -smp options),
the preference of sockets/cores in -smp parsing is considered liable
to change, and actually we are going to change it in a coming commit.
So it'll be more stable to use detailed -smp CLIs in testing if we
have strong dependency on the parsing results.
pc_dynamic_cpu_cfg currently assumes/needs that there will be 2 CPU
sockets with "-smp 2". To avoid breaking the test because of parsing
logic change, now explicitly use "-smp 2,sockets=2".
Signed-off-by: Yanan Wang <wangyanan55@huawei.com>
Reviewed-by: Andrew Jones <drjones@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
tests/qtest/numa-test.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/qtest/numa-test.c b/tests/qtest/numa-test.c
index c677cd63c4..fd7a2e80a0 100644
--- a/tests/qtest/numa-test.c
+++ b/tests/qtest/numa-test.c
@@ -265,7 +265,8 @@ static void pc_dynamic_cpu_cfg(const void *data)
QTestState *qs;
g_autofree char *cli = NULL;
- cli = make_cli(data, "-nodefaults --preconfig -machine smp.cpus=2");
+ cli = make_cli(data, "-nodefaults --preconfig "
+ "-machine smp.cpus=2,smp.sockets=2");
qs = qtest_init(cli);
/* create 2 numa nodes */
--
2.19.1
- [PATCH v12 00/16] machine: smp parsing fixes and improvement, Yanan Wang, 2021/09/28
- [PATCH v12 01/16] qapi/machine: Fix an incorrect comment of SMPConfiguration, Yanan Wang, 2021/09/28
- [PATCH v12 10/16] machine: Use ms instead of global current_machine in sanity-check, Yanan Wang, 2021/09/28
- [PATCH v12 07/16] qtest/numa-test: Use detailed -smp CLIs in pc_dynamic_cpu_cfg,
Yanan Wang <=
- [PATCH v12 02/16] machine: Deprecate "parameter=0" SMP configurations, Yanan Wang, 2021/09/28
- [PATCH v12 04/16] machine: Uniformly use maxcpus to calculate the omitted parameters, Yanan Wang, 2021/09/28
- [PATCH v12 09/16] machine: Prefer cores over sockets in smp parsing since 6.2, Yanan Wang, 2021/09/28
- [PATCH v12 03/16] machine: Minor refactor/fix for the smp parsers, Yanan Wang, 2021/09/28
- [PATCH v12 06/16] machine: Improve the error reporting of smp parsing, Yanan Wang, 2021/09/28
- [PATCH v12 08/16] qtest/numa-test: Use detailed -smp CLIs in test_def_cpu_split, Yanan Wang, 2021/09/28
- [PATCH v12 16/16] machine: Make smp_parse return a boolean, Yanan Wang, 2021/09/28