[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v10 07/14] qtest/numa-test: Use detailed -smp CLIs in test_def_cp
From: |
Yanan Wang |
Subject: |
[PATCH v10 07/14] qtest/numa-test: Use detailed -smp CLIs in test_def_cpu_split |
Date: |
Sun, 26 Sep 2021 16:45:34 +0800 |
Since commit 80d7835749 (qemu-options: rewrite help for -smp options),
the preference of sockets/cores in -smp parsing is considered liable
to change, and actually we are going to change it in a coming commit.
So it'll be more stable to use detailed -smp CLIs in the testcases
that have strong dependency on the parsing results.
Currently, test_def_cpu_split use "-smp 8" and will get 8 CPU sockets
based on current parsing rule. But if we change to prefer cores over
sockets we will get one CPU socket with 8 cores, and this testcase
will not get expected numa set by default on x86_64 (Ok on aarch64).
So now explicitly use "-smp 8,sockets=8" to avoid affect from parsing
logic change.
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Yanan Wang <wangyanan55@huawei.com>
Reviewed-by: Andrew Jones <drjones@redhat.com>
---
tests/qtest/numa-test.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/qtest/numa-test.c b/tests/qtest/numa-test.c
index fd7a2e80a0..90bf68a5b3 100644
--- a/tests/qtest/numa-test.c
+++ b/tests/qtest/numa-test.c
@@ -42,7 +42,8 @@ static void test_def_cpu_split(const void *data)
g_autofree char *s = NULL;
g_autofree char *cli = NULL;
- cli = make_cli(data, "-machine smp.cpus=8 -numa node,memdev=ram -numa
node");
+ cli = make_cli(data, "-machine smp.cpus=8,smp.sockets=8 "
+ "-numa node,memdev=ram -numa node");
qts = qtest_init(cli);
s = qtest_hmp(qts, "info numa");
--
2.19.1
- [PATCH v10 00/14] machine: smp parsing fixes and improvement, Yanan Wang, 2021/09/26
- [PATCH v10 01/14] machine: Deprecate "parameter=0" SMP configurations, Yanan Wang, 2021/09/26
- [PATCH v10 04/14] machine: Set the value of cpus to match maxcpus if it's omitted, Yanan Wang, 2021/09/26
- [PATCH v10 03/14] machine: Uniformly use maxcpus to calculate the omitted parameters, Yanan Wang, 2021/09/26
- [PATCH v10 02/14] machine: Minor refactor/fix for the smp parsers, Yanan Wang, 2021/09/26
- [PATCH v10 07/14] qtest/numa-test: Use detailed -smp CLIs in test_def_cpu_split,
Yanan Wang <=
- [PATCH v10 05/14] machine: Improve the error reporting of smp parsing, Yanan Wang, 2021/09/26
- [PATCH v10 11/14] machine: Make smp_parse generic enough for all arches, Yanan Wang, 2021/09/26
- [PATCH v10 08/14] machine: Prefer cores over sockets in smp parsing since 6.2, Yanan Wang, 2021/09/26
- [PATCH v10 12/14] machine: Remove smp_parse callback from MachineClass, Yanan Wang, 2021/09/26
- [PATCH v10 06/14] qtest/numa-test: Use detailed -smp CLIs in pc_dynamic_cpu_cfg, Yanan Wang, 2021/09/26
- [PATCH v10 13/14] machine: Move smp_prefer_sockets to struct SMPCompatProps, Yanan Wang, 2021/09/26
- [PATCH v10 09/14] machine: Use ms instead of global current_machine in sanity-check, Yanan Wang, 2021/09/26
- [PATCH v10 10/14] machine: Tweak the order of topology members in struct CpuTopology, Yanan Wang, 2021/09/26