RE: [PATCH v2 11/53] target/hexagon: delete unused hexagon_debug() method

[Taylor Simpson]

> -----Original Message-----
> From: Daniel P. Berrangé <berrange@redhat.com>
> Subject: [PATCH v2 11/53] target/hexagon: delete unused hexagon_debug()
> method
> 
> This method isn't used in any code and its functionality is already available 
> via
> the 'info registers' HMP command.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  target/hexagon/cpu.c      | 5 -----
>  target/hexagon/internal.h | 1 -
>  2 files changed, 6 deletions(-)
> 
> diff --git a/target/hexagon/cpu.c b/target/hexagon/cpu.c index
> 3338365c16..14c628db7a 100644
> --- a/target/hexagon/cpu.c
> +++ b/target/hexagon/cpu.c
> @@ -169,11 +169,6 @@ static void hexagon_dump_state(CPUState *cs, FILE
> *f, int flags)
>      hexagon_dump(env, f);
>  }
> 
> -void hexagon_debug(CPUHexagonState *env) -{
> -    hexagon_dump(env, stdout);
> -}
> -
>  static void hexagon_cpu_set_pc(CPUState *cs, vaddr value)  {
>      HexagonCPU *cpu = HEXAGON_CPU(cs);
> diff --git a/target/hexagon/internal.h b/target/hexagon/internal.h index
> 6b20affdfa..167e91026a 100644
> --- a/target/hexagon/internal.h
> +++ b/target/hexagon/internal.h
> @@ -31,7 +31,6 @@
> 
>  int hexagon_gdb_read_register(CPUState *cpu, GByteArray *buf, int reg);
> int hexagon_gdb_write_register(CPUState *cpu, uint8_t *buf, int reg);
> -void hexagon_debug(CPUHexagonState *env);
> 
>  extern const char * const hexagon_regnames[TOTAL_PER_THREAD_REGS];

Reviewed-by: Taylor Simpson <tsimpson@quicinc.com>