[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v9 09/16] machine: Use ms instead of global current_machine in sa
From: |
Yanan Wang |
Subject: |
[PATCH v9 09/16] machine: Use ms instead of global current_machine in sanity-check |
Date: |
Fri, 10 Sep 2021 15:30:18 +0800 |
In the sanity-check of smp_cpus and max_cpus against mc in function
machine_set_smp(), we are now using ms->smp.max_cpus for the check
but using current_machine->smp.max_cpus in the error message.
Tweak this by uniformly using the local ms.
Signed-off-by: Yanan Wang <wangyanan55@huawei.com>
Reviewed-by: Andrew Jones <drjones@redhat.com>
Reviewed-by: Pankaj Gupta <pankaj.gupta@ionos.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
---
hw/core/machine.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/core/machine.c b/hw/core/machine.c
index 0df597f99c..1ad5dac3e8 100644
--- a/hw/core/machine.c
+++ b/hw/core/machine.c
@@ -881,7 +881,7 @@ static void machine_set_smp(Object *obj, Visitor *v, const
char *name,
} else if (ms->smp.max_cpus > mc->max_cpus) {
error_setg(errp, "Invalid SMP CPUs %d. The max CPUs "
"supported by machine '%s' is %d",
- current_machine->smp.max_cpus,
+ ms->smp.max_cpus,
mc->name, mc->max_cpus);
}
--
2.23.0
- [PATCH v9 02/16] machine: Minor refactor/fix for the smp parsers, (continued)
- [PATCH v9 02/16] machine: Minor refactor/fix for the smp parsers, Yanan Wang, 2021/09/10
- [PATCH v9 11/16] machine: Make smp_parse generic enough for all arches, Yanan Wang, 2021/09/10
- [PATCH v9 12/16] machine: Remove smp_parse callback from MachineClass, Yanan Wang, 2021/09/10
- [PATCH v9 04/16] machine: Set the value of cpus to match maxcpus if it's omitted, Yanan Wang, 2021/09/10
- [PATCH v9 13/16] machine: Move smp_prefer_sockets to struct SMPCompatProps, Yanan Wang, 2021/09/10
- [PATCH v9 07/16] qtest/numa-test: Use detailed -smp CLI in test_def_cpu_split, Yanan Wang, 2021/09/10
- [PATCH v9 16/16] tests/unit: Add a unit test for smp parsing, Yanan Wang, 2021/09/10
- [PATCH v9 10/16] machine: Tweak the order of topology members in struct CpuTopology, Yanan Wang, 2021/09/10
- [PATCH v9 09/16] machine: Use ms instead of global current_machine in sanity-check,
Yanan Wang <=
- [PATCH v9 14/16] machine: Put all sanity-check in the generic SMP parser, Yanan Wang, 2021/09/10
- [PATCH v9 15/16] machine: Split out the smp parsing code, Yanan Wang, 2021/09/10
- Re: [PATCH v9 00/16] machine: smp parsing fixes and improvement, wangyanan (Y), 2021/09/17