|
From: | Matthew Rosato |
Subject: | Re: [PATCH] s390x: Replace PAGE_SIZE, PAGE_SHIFT and PAGE_MASK |
Date: | Wed, 1 Sep 2021 09:43:04 -0400 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 |
On 9/1/21 8:58 AM, Thomas Huth wrote:
The PAGE_SIZE macro is causing trouble on Alpine Linux since it clashes with a macro from a system header there. We already have the TARGET_PAGE_SIZE, TARGET_PAGE_MASK and TARGET_PAGE_BITS macros in QEMU anyway, so let's simply replace the PAGE_SIZE, PAGE_MASK and PAGE_SHIFT macro with their TARGET_* counterparts. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/572 Signed-off-by: Thomas Huth <thuth@redhat.com>
Code looks good, also took it for a quick sanity test with s390x kvm host against vfio-pci and virtio-pci, works as expected. Thanks Thomas!
Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com>
[Prev in Thread] | Current Thread | [Next in Thread] |