Re: [PATCH v1 2/9] s390x: toplogy: adding drawers and books to smp parsing

[Cornelia Huck]

On Thu, Jul 15 2021, Markus Armbruster <armbru@redhat.com> wrote:

> Pierre Morel <pmorel@linux.ibm.com> writes:
>
>> On 7/15/21 8:16 AM, Markus Armbruster wrote:
>>> Pierre Morel <pmorel@linux.ibm.com> writes:
>>> 
>>>> Drawers and Books are levels 4 and 3 of the S390 CPU
>>>> topology.
>>>> We allow the user to define these levels and we will
>>>> store the values inside the S390CcwMachineState.
>>> 
>>> Double-checking: are these members specific to S390?
>>
>> Yes AFAIK
>
> Makes me wonder whether they should be conditional on TARGET_S390X.
>
> What happens when you specify them for another target?  Silently
> ignored, or error?

I'm wondering whether we should include them in the base machine state
and treat them as we treat 'dies' (i.e. the standard parser errors out
if they are set, and only the s390x parser supports them.)

[I remember that we had a discussion ages ago about which parameters
should be included in the cpu topology, but I cannot recall the details :/]