Re: [RFC v6 02/13] hw/s390x: rename tod-qemu.c to tod-tcg.c

[Al Cho]

On Thu, 2021-07-01 at 12:11 +0200, Thomas Huth wrote:
> On 29/06/2021 16.19, Cho, Yu-Chen wrote:
> > we stop short of renaming the actual qom object though,
> > so type remains TYPE_QEMU_S390_TOD, ie "s390-tod-qemu".
> > 
> > Signed-off-by: Claudio Fontana <cfontana@suse.de>
> > Reviewed-by: David Hildenbrand <david@redhat.com>
> > Reviewed-by: Cornelia Huck <cohuck@redhat.com>
> > Signed-off-by: Cho, Yu-Chen <acho@suse.com>
> > ---
> >   hw/s390x/meson.build               | 2 +-
> >   hw/s390x/{tod-qemu.c => tod-tcg.c} | 0
> >   2 files changed, 1 insertion(+), 1 deletion(-)
> >   rename hw/s390x/{tod-qemu.c => tod-tcg.c} (100%)
> > 
> > diff --git a/hw/s390x/meson.build b/hw/s390x/meson.build
> > index 327e9c93af..02e81a9467 100644
> > --- a/hw/s390x/meson.build
> > +++ b/hw/s390x/meson.build
> > @@ -16,7 +16,7 @@ s390x_ss.add(files(
> >     'sclp.c',
> >     'sclpcpu.c',
> >     'sclpquiesce.c',
> > -  'tod-qemu.c',
> > +  'tod-tcg.c',
> >     'tod.c',
> >   ))
> >   s390x_ss.add(when: 'CONFIG_KVM', if_true: files(
> > diff --git a/hw/s390x/tod-qemu.c b/hw/s390x/tod-tcg.c
> > similarity index 100%
> > rename from hw/s390x/tod-qemu.c
> > rename to hw/s390x/tod-tcg.c
> 
> Might be worth the effort to also change the comment at the top of
> the file 
> ("TCG implementation" instead of "QEMU implementation").
> 

right, will change it.

Thanks,
      AL

> Anyway:
> Reviewed-by: Thomas Huth <thuth@redhat.com>
>