[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 2/7] target/arm: Make sure that commpage's tb->size != 0
From: |
Cornelia Huck |
Subject: |
[PULL 2/7] target/arm: Make sure that commpage's tb->size != 0 |
Date: |
Thu, 6 May 2021 17:44:18 +0200 |
From: Ilya Leoshkevich <iii@linux.ibm.com>
tb_gen_code() assumes that tb->size must never be zero, otherwise it
may produce spurious exceptions. For ARM this may happen when creating
a translation block for the commpage.
Fix by pretending that commpage translation blocks have at least one
instruction.
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20210416154939.32404-3-iii@linux.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---
target/arm/translate.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/target/arm/translate.c b/target/arm/translate.c
index 43ff0d4b8ac2..c8dbb03d6db8 100644
--- a/target/arm/translate.c
+++ b/target/arm/translate.c
@@ -9097,6 +9097,7 @@ static void arm_tr_translate_insn(DisasContextBase
*dcbase, CPUState *cpu)
unsigned int insn;
if (arm_pre_translate_insn(dc)) {
+ dc->base.pc_next += 4;
return;
}
@@ -9166,6 +9167,7 @@ static void thumb_tr_translate_insn(DisasContextBase
*dcbase, CPUState *cpu)
bool is_16bit;
if (arm_pre_translate_insn(dc)) {
+ dc->base.pc_next += 2;
return;
}
--
2.30.2
- [PULL 0/7] s390x update, Cornelia Huck, 2021/05/06
- [PULL 1/7] target/s390x: Fix translation exception on illegal instruction, Cornelia Huck, 2021/05/06
- [PULL 3/7] target/xtensa: Make sure that tb->size != 0, Cornelia Huck, 2021/05/06
- [PULL 2/7] target/arm: Make sure that commpage's tb->size != 0,
Cornelia Huck <=
- [PULL 4/7] accel/tcg: Assert that tb->size != 0 after translation, Cornelia Huck, 2021/05/06
- [PULL 6/7] hw/s390x/ccw: Register qbus type in abstract TYPE_CCW_DEVICE parent, Cornelia Huck, 2021/05/06
- [PULL 5/7] vfio-ccw: Permit missing IRQs, Cornelia Huck, 2021/05/06
- [PULL 7/7] vfio-ccw: Attempt to clean up all IRQs on error, Cornelia Huck, 2021/05/06
- Re: [PULL 0/7] s390x update, Peter Maydell, 2021/05/11