[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC v2 05/13] target/s390x: start moving TCG-only code to tcg/
From: |
Claudio Fontana |
Subject: |
Re: [RFC v2 05/13] target/s390x: start moving TCG-only code to tcg/ |
Date: |
Tue, 20 Apr 2021 15:40:10 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 |
On 4/20/21 3:16 PM, David Hildenbrand wrote:
> On 20.04.21 12:36, Claudio Fontana wrote:
>> move everything related to translate, as well as HELPER code in tcg/
>>
>> mmu_helper.c stays put for now, as it contains both TCG and KVM code.
>>
>
> How hard would it be to split that up as well?
>
>> The internal.h file is renamed to s390x-internal.h, because of the
>> risk of collision with other files with the same name.
>
> Can we move that change into a separate patch, so all we're left with
> are effective renames?
>
>
I think it works as long as we do the s390x-internal.h rename first,
and then the rest, otherwise the intermediate commit could break.
Will work on it, thanks,
Claudio
[RFC v2 05/13] target/s390x: start moving TCG-only code to tcg/, Claudio Fontana, 2021/04/20
[RFC v2 11/13] target/s390x: move kvm files into kvm/, Claudio Fontana, 2021/04/20
[RFC v2 07/13] target/s390x: split cpu-dump from helper.c, Claudio Fontana, 2021/04/20
[RFC v2 08/13] target/s390x: make helper.c sysemu-only, Claudio Fontana, 2021/04/20
[RFC v2 09/13] target/s390x: use kvm_enabled() to wrap call to kvm_s390_get_hpage_1m, Claudio Fontana, 2021/04/20
[RFC v2 06/13] target/s390x: move sysemu-only code out to cpu-sysemu.c, Claudio Fontana, 2021/04/20
[RFC v2 13/13] MAINTAINERS: update s390x directories, Claudio Fontana, 2021/04/20
[RFC v2 10/13] target/s390x: remove kvm-stub.c, Claudio Fontana, 2021/04/20
[RFC v2 12/13] target/s390x: split sysemu part of cpu models, Claudio Fontana, 2021/04/20