Re: [PATCH v2 1/6] qdev: define list of archs with virtio-pci or virtio-ccw

[Cornelia Huck]

On Fri, 19 Mar 2021 14:25:32 +0100
Laurent Vivier <laurent@vivier.eu> wrote:

> This is used to define virtio-*-pci and virtio-*-ccw aliases
> rather than substracting the CCW architecture from all the others.
> 
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> ---
>  include/sysemu/arch_init.h |  7 +++++
>  softmmu/qdev-monitor.c     | 53 ++++++++++++++++++--------------------
>  2 files changed, 32 insertions(+), 28 deletions(-)
> 
> diff --git a/include/sysemu/arch_init.h b/include/sysemu/arch_init.h
> index 54f069d49126..7217a822a14b 100644
> --- a/include/sysemu/arch_init.h
> +++ b/include/sysemu/arch_init.h
> @@ -35,4 +35,11 @@ extern const uint32_t arch_type;
>  int kvm_available(void);
>  int xen_available(void);
>  

Maybe add a comment

/* default virtio transport per architecture */

> +#define QEMU_ARCH_VIRTIO_PCI (QEMU_ARCH_ALPHA | QEMU_ARCH_ARM | \
> +                              QEMU_ARCH_HPPA | QEMU_ARCH_I386 | \
> +                              QEMU_ARCH_MIPS | QEMU_ARCH_PPC |  \
> +                              QEMU_ARCH_RISCV | QEMU_ARCH_SH4 | \
> +                              QEMU_ARCH_SPARC | QEMU_ARCH_XTENSA)
> +#define QEMU_ARCH_VIRTIO_CCW (QEMU_ARCH_S390X)
> +
>  #endif

Reviewed-by: Cornelia Huck <cohuck@redhat.com>