Re: [PATCH 2/4] iotests: Revert "iotests: use -ccw on s390x for 040, 139, and 182"

[Laurent Vivier]

Le 19/03/2021 à 12:43, Cornelia Huck a écrit :
> On Thu, 18 Mar 2021 23:39:05 +0100
> Laurent Vivier <laurent@vivier.eu> wrote:
> 
>> Commit f1d5516ab583 introduces a test in some iotests to check if
>> the machine is a s390-ssw-virtio and to select virtio-*-ccw rather
> 
> s/ssw/ccw/
> 
>> than virtio-*-pci.
>>
>> We don't need that because QEMU already provides aliases to use the correct
>> virtio interface according to the machine type.
> 
> Maybe add a comment that this also enables virtio-mmio?

ok

>>
>> This patch removes all virtio-*-pci and virtio-*-ccw to use virtio-*
>> instead.
>>
>> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
>> cc: Cornelia Huck <cohuck@redhat.com>
>> ---
>>  blockdev.c                    |  6 +-----
> 
> Hm, that also tweaks how -drive behaves, IIUC. Intended, I think; but
> worth a note as well?
> 

You're right. I think it needs a separate patch, in fact.

Thanks,
Laurent