|
From: | Paolo Bonzini |
Subject: | Re: compile warning in i8259.c |
Date: | Mon, 15 Mar 2021 17:43:58 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 |
On 15/03/21 16:55, Philippe Mathieu-Daudé wrote:
Since you ask, I'd love to have things solved differently... One PIC has 8 IRQs, so we should model 2 cascaded PICs as 2 cascaded QOM PICs. But this code is so old and heavily used that my desire is unlikely to be realized. And your patch is simpler :>
They are modeled like that, see i8259_init. Perhaps you mean that pic_read_irq should call itself recursively on the slave PIC if irq == 2 && s->master?
Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |