[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/1] hw/s390x: modularize virtio-gpu-ccw
From: |
Gerd Hoffmann |
Subject: |
Re: [PATCH 1/1] hw/s390x: modularize virtio-gpu-ccw |
Date: |
Fri, 19 Feb 2021 09:45:45 +0100 |
Hi,
> I don't see way around target-specific modules. With the modifications
> suggested by Thomas and Connie, I was able to get the new module to
> compile regardless of the target,
Cool (should have checked all mails before sending replies ...).
> but that "fixes" s390x at the expense
> of breaking all the other targets. For example:
> ./qemu-system-x86_64 -device help
> Type 'virtio-gpu-ccw' is missing its parent 'virtio-ccw-device'
> Aborted
Hmm, this is a new failure variant. In the PCI case (see other mail)
the module doesn't load in the first place due to missing symbols.
Maybe we need a type_register_mayfail() variant which doesn't abort in
case the parent isn't found (see also commit
501093207eb1ed4845e0a65ee1ce7db7b9676e0b).
HTH,
Gerd