Re: [PATCH] configure: Only build s390-ccw BIOS for system emulation

[Thomas Huth]

On 24/01/2021 17.17, Philippe Mathieu-Daudé wrote:
> It is pointless to build the s390-ccw BIOS when only user-mode
> emulation is built. Only build it when system mode emulation is
> selected.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>   configure | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 6f6a319c2f6..d5e97ff2d52 100755
> --- a/configure
> +++ b/configure
> @@ -5453,7 +5453,7 @@ if { test "$cpu" = "i386" || test "$cpu" = "x86_64"; } && 
> \
>   fi
>   
>   # Only build s390-ccw bios if we're on s390x and the compiler has -march=z900
> -if test "$cpu" = "s390x" ; then
> +if test "$cpu" = "s390x" && test "$softmmu" = yes; then

Actually, you could even improve by checking whether we're building the 
s390x-softmmu target (the bios is also not required if we're just building 
the x86_64-softmmu target on a s390x host, for example).

 Thomas