[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests/acceptance: bound the size of readline in s390_ccw_vir
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [PATCH] tests/acceptance: bound the size of readline in s390_ccw_virtio |
|
Date: |
Tue, 5 Jan 2021 12:47:20 +0000 |
|
User-agent: |
Mutt/1.14.6 (2020-07-11) |
On Tue, Jan 05, 2021 at 12:44:05PM +0000, Alex Bennée wrote:
> The read binary data as text via a PPM export of the frame buffer
> seems a bit sketchy and it did blow up in the real world when the
> assertion failed:
>
> https://gitlab.com/qemu-project/qemu/-/jobs/943183183
>
> However short of cleaning up the test to be more binary focused at
> least limit the attempt to dump the whole file as hexified zeros in
> the logs.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> tests/acceptance/machine_s390_ccw_virtio.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|