Re: [PATCH v3] s390/kvm: fix diag318 propagation and reset functionality

[Collin Walling]

On 11/15/20 11:47 AM, Thomas Huth wrote:
> On 13/11/2020 23.10, Collin Walling wrote:
>> The Control Program Name Code (CPNC) portion of the diag318
>> info must be set within the SIE block of each VCPU in the
>> configuration. The handler will iterate through each VCPU
>> and dirty the diag318_info reg to be synced with KVM on a
>> subsequent sync_regs call.
>>
>> Additionally, the diag318 info resets must be handled via
>> userspace. As such, QEMU will reset this value for each
>> VCPU during a modified clear, load normal, and load clear
>> reset event.
>>
>> Fixes: fabdada9357b ("s390: guest support for diagnose 0x318")
>> Signed-off-by: Collin Walling <walling@linux.ibm.com>
>> ---
> 
> Patch looks fine to me now.
> 
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> 
> 

Thanks for the feedback!

-- 
Regards,
Collin

Stay safe and stay healthy